-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test also on Python 3.5 and 3.6 #51
Conversation
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. However, please apply it also to the .travis.yml, so that we can ensure that it's well tested on CI too.
(I think we can nowadays disable py25, py26, py33, py34 there, at the same time).
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@kaplun New commit added and all tests pass too on Python 3.5 and 3.6 Do you really want to disable the testing with tox and Travis for py25, py26, py33, py34 ? |
Note that I am fine with this on my side: I care only for 2.7, 3.5 and 3.6. |
@kaplun Let me push the removal of older pythons and you can pick or ignore these changes as you please. |
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Yeah, actually since you are fine with Python 2.7, I think it's better to reduce the testing matrix to ease Travis load. AFAIK |
@kaplun beside all users of invenio and invenio forks (https://github.com/search?l=Python&q=intbitset&type=Code) these are a few other users:
But I guess this will not be an issue to drop older pythons support there |
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
In any case I also fixed the |
* NEW Ensures support for Python 3.5 and 3.6. * NEW Removes support for Python 2.5, 2.6, 3.3 and 3.4. (closes inveniosoftware-contrib#51) Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@kaplun Thanks for the merge squashing! I could have done the squashing alright too. |
👍 didn't dare ask further 💃 |
Signed-off-by: Philippe Ombredanne pombredanne@nexb.com