Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test also on Python 3.5 and 3.6 #51

Closed

Conversation

pombredanne
Copy link
Collaborator

Signed-off-by: Philippe Ombredanne pombredanne@nexb.com

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Copy link
Member

@kaplun kaplun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, please apply it also to the .travis.yml, so that we can ensure that it's well tested on CI too.
(I think we can nowadays disable py25, py26, py33, py34 there, at the same time).

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Copy link
Collaborator Author

@kaplun New commit added and all tests pass too on Python 3.5 and 3.6

Do you really want to disable the testing with tox and Travis for py25, py26, py33, py34 ?

@pombredanne
Copy link
Collaborator Author

Note that I am fine with this on my side: I care only for 2.7, 3.5 and 3.6.

@pombredanne
Copy link
Collaborator Author

pombredanne commented Jan 30, 2017

@kaplun Let me push the removal of older pythons and you can pick or ignore these changes as you please.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@kaplun
Copy link
Member

kaplun commented Jan 30, 2017

Yeah, actually since you are fine with Python 2.7, I think it's better to reduce the testing matrix to ease Travis load. AFAIK intbitset independent library (beside your project) had been used only by Invenio 2.x which is anyway deprecated, so I believe we can nicely upgrade the requirements.

@pombredanne
Copy link
Collaborator Author

pombredanne commented Jan 30, 2017

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Copy link
Collaborator Author

In any case I also fixed the setup.py classifiers accordingly.

kaplun pushed a commit to kaplun/intbitset that referenced this pull request Feb 1, 2017
* NEW Ensures support for Python 3.5 and 3.6.
* NEW Removes support for Python 2.5, 2.6, 3.3 and 3.4.
  (closes inveniosoftware-contrib#51)

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@kaplun kaplun closed this in #55 Feb 1, 2017
@pombredanne
Copy link
Collaborator Author

@kaplun Thanks for the merge squashing! I could have done the squashing alright too.

@pombredanne pombredanne deleted the patch-4 branch February 1, 2017 12:16
@kaplun
Copy link
Member

kaplun commented Feb 1, 2017

👍 didn't dare ask further 💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants