Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accounts: create manage hooks #2

Closed
eamonnmag opened this issue Aug 19, 2015 · 14 comments
Closed

accounts: create manage hooks #2

eamonnmag opened this issue Aug 19, 2015 · 14 comments
Assignees
Milestone

Comments

@eamonnmag
Copy link
Contributor

So that we can create users for example for inveniomanage, e.g.

inveniomanage user createsuperuser --u eamonn --p mypassword --e eamonn@helloworld.com
inveniomanage user createuser --u eamonn --p mypassword --e eamonn@helloworld.com
@jirikuncar
Copy link
Member

Proposal

@eamonnmag I like your proposal, I have just few consistency suggestions:

inveniomanage accounts create [--superadmin] -u/--user <name> -e/--email <valid_email> [-p/--passoword]

Question

Shall we create commands for deleting and modifying users too?

@jirikuncar jirikuncar added this to the v0.2.0 milestone Aug 19, 2015
@eamonnmag
Copy link
Contributor Author

I like your option better. I was starting from how django does it. They only have

 changepassword
 createsuperuser

I think that having the ability to create and modify any type of user from this tool would be very useful though.

@jirikuncar
Copy link
Member

👍 for changepassword

@tiborsimko
Copy link
Member

👍 and it'll be good to grow options later to be able to delete users, make them inactive, etc. (E.g. merge users would be fun to have later.)

@lnielsen
Copy link
Member

👍 for adding simple options. Especially useful for development and bootstrapping. In a running production I would prefer to have most stuff in the UI (which naturally doesn't exclude also having it in CLI as well).

@eamonnmag
Copy link
Contributor Author

addrole would also be good. We need to add roles to users, and there's nothing I see on the front end side to do that yet. I may make a start on this soon, since we really need it.

@jirikuncar
Copy link
Member

@eamonnmag addrole should be probably part of invenio-access package. (cc @hachreak)

@eamonnmag
Copy link
Contributor Author

Ah, ok, I didn't know about that. Where is that package currently residing? I can't find it anywhere.

@jirikuncar
Copy link
Member

@eamonnmag created here https://github.com/inveniosoftware/invenio-access and it's waiting for inveniosoftware/invenio#3328 to be integrated first.

@eamonnmag
Copy link
Contributor Author

Great, thanks @jirikuncar!

@lnielsen
Copy link
Member

lnielsen commented Sep 2, 2015

Btw, just for reference here's the commands from Flask-Security: https://github.com/mattupstate/flask-security/blob/develop/flask_security/script.py:

  • Create user
  • Create role
  • Add/remove role to/from user
  • Activate/deactivate user

@eamonnmag
Copy link
Contributor Author

Can we not just use this?

@lnielsen
Copy link
Member

lnielsen commented Sep 3, 2015

You mean use Flask-Security, or just use the names?

Names: Yes, I'm fine with them.
Flask-Security: Yes as well, but on a longer time scale. I've already done some integration work for Flask-AppFactory with Flask-Security.

@jirikuncar
Copy link
Member

Superseded by #32.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants