Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y: Duplicate id's in GridResponsiveSidebarColumn #2352

Closed
jennur opened this issue Aug 17, 2023 · 0 comments · Fixed by #2405 or inveniosoftware/invenio-search-ui#187
Closed

A11y: Duplicate id's in GridResponsiveSidebarColumn #2352

jennur opened this issue Aug 17, 2023 · 0 comments · Fixed by #2405 or inveniosoftware/invenio-search-ui#187

Comments

@jennur
Copy link
Member

jennur commented Aug 17, 2023

The mobile tablet computer only classes has display: none when not visible, but they should also have visibility: hidden to be hidden from assistive technologies (this is currently causing a ton of duplicate id a11y errors).

From my understanding visibility: hidden should do the job, but it needs to be tested.

Edit: From researching this issue, the id's need to be unique regardless of their visibility. This means we need to find a way to assign unique id's to elements for each hidden/visible state. I.e. for the GridResponsiveSidebarColumn, we need to set one id for the input elements in the mobile/tablet version, and one for the desktop version.

Other possible solutions TO BE TESTED (if the id is only used to connect the input with the label):

  • Replace the id with aria-label on the inputs
@jennur jennur changed the title Responsive classes should be aria hidden when not visible Duplicate id's in GridResponsiveSidebarColumn Sep 6, 2023
@jennur jennur changed the title Duplicate id's in GridResponsiveSidebarColumn A11y: Duplicate id's in GridResponsiveSidebarColumn Sep 12, 2023
@jennur jennur self-assigned this Sep 14, 2023
@jennur jennur assigned jennur and unassigned jennur Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant