Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review theme module structure #63

Closed
ppanero opened this issue Feb 20, 2020 · 1 comment · Fixed by #84
Closed

review theme module structure #63

ppanero opened this issue Feb 20, 2020 · 1 comment · Fixed by #84
Assignees
@ppanero
Labels
bug Something isn't working good first issue Good for newcomers
Projects
InvenioRDM March Board

Comments

@ppanero
Copy link
Member

ppanero commented Feb 20, 2020

Is the __init__.py file needed: I assume yes cuz is a python module. Next question, is the version import needed? I think is not, shall it be removed?

from ..version import __version__

__all__ = ('__version__', )
@ppanero ppanero added this to To Do in InvenioRDM March Board via automation Feb 20, 2020
@ppanero ppanero mentioned this issue Feb 20, 2020
Merged
@fenekku
Copy link
Contributor

fenekku commented Feb 27, 2020

Definitely not needed. We can remove it.

@lnielsen lnielsen added bug Something isn't working good first issue Good for newcomers labels Mar 18, 2020
@ppanero ppanero mentioned this issue Mar 23, 2020
Closed
33 tasks
@ppanero ppanero moved this from To Do to In Progress in InvenioRDM March Board Mar 25, 2020
@ppanero ppanero self-assigned this Mar 25, 2020
@ppanero ppanero mentioned this issue Mar 25, 2020
Merged
@ppanero ppanero moved this from In Progress to In Review in InvenioRDM March Board Mar 25, 2020
InvenioRDM March Board automation moved this from In Review to Done Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ppanero ppanero

Labels
bug Something isn't working good first issue Good for newcomers
Projects
No open projects
InvenioRDM March Board
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

theme: remove unnecessary version export ppanero/invenio-rdm-records
3 participants
@lnielsen @fenekku @ppanero