Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

templates: common template macros #6

Closed
lnielsen opened this issue Oct 29, 2015 · 5 comments
Closed

templates: common template macros #6

lnielsen opened this issue Oct 29, 2015 · 5 comments
Labels
Type: enhancement
Milestone
v1.0.0

Comments

@lnielsen
Copy link
Member

We should add a helper library of template macros that can be used to make formatting record pages easier (e.g. adding et.al. to list of authors).
@lnielsen lnielsen added this to the v1.0.0 milestone Oct 29, 2015
@jirikuncar
Copy link
Member

invenio-formatter?

@lnielsen
Copy link
Member Author

lnielsen commented Nov 2, 2015

Weren't we going to kill invenio-formatter? or you propose that we make a new module with all these extra jinja2 goodies?

@jirikuncar
Copy link
Member

invenio-formatter can contain only Jinja2 goodies such as macros, filters, etc. that can be used not only for formatting records but as a base for any theme package.

@lnielsen
Copy link
Member Author

lnielsen commented Nov 2, 2015

Sounds good to me - i.e. this ticket can be closed once we bootstrap the new module.

@jirikuncar jirikuncar mentioned this issue Nov 2, 2015
Closed
@tiborsimko
Copy link
Member

Closing as per the release of invenio-formatter v1.0.0a. The common formatting goodies can be further discussed there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: enhancement
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
3 participants
@jirikuncar @tiborsimko @lnielsen