This repository has been archived by the owner on May 3, 2020. It is now read-only.
upgrades: InnoDB upgrade fix #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "SELECT CONCAT('ALTER TABLE ',TABLE_NAME,' ENGINE=InnoDB;')" | ||
| " FROM INFORMATION_SCHEMA.TABLES" | ||
| " WHERE ENGINE='MyISAM'" | ||
| " AND table_schema = %s", | ||
| (current_app.config.get('CFG_DATABASE_NAME'),) | ||
| ) | ||
| [run_sql(row[0]) for row in rows] |
There was a problem hiding this comment.
for row in rows:
run_sql(row[0])?
There was a problem hiding this comment.
for row in rows:
run_sql("ALTER TABLE '%s' ENGINE=InnoDB;", row[0])There was a problem hiding this comment.
I'll try to do it using alembic instead, I'll update the PR asap
There was a problem hiding this comment.
It's not gonna happen 😢
| @@ -39,13 +39,14 @@ def do_upgrade(): | |||
| """Carry out the upgrade.""" | |||
| from flask import current_app | |||
| if current_app.config.get('CFG_DATABASE_TYPE') == 'mysql': | |||
| run_sql( | |||
| rows = run_sql( | |||
| "SELECT CONCAT('ALTER TABLE ',TABLE_NAME,' ENGINE=InnoDB;')" | |||
egabancho
force-pushed
the
innodb-fix-upgrade
branch
from
8038ed8
to
8c434c1
Compare
| (current_app.config.get('CFG_DATABASE_NAME'),) | ||
| ) | ||
| for table_name in table_names: | ||
| run_sql("ALTER TABLE `%s` ENGINE=InnoDB" % (table_name[0],)) |
There was a problem hiding this comment.
it doesn't make sense to change because actually this query is valid only for mysql.
|
It seems to be running just fine for CDS database, although it takes a lot of time |
|
|
* FIX Runs the sql statement which actually changes the engine from MyISAM to InnoDB. Signed-off-by: Esteban J. G. Gabancho <esteban.gabancho@gmail.com>
egabancho
force-pushed
the
innodb-fix-upgrade
branch
from
8c434c1
to
b0cbb9c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MyISAM to InnoDB.
Signed-off-by: Esteban J. G. Gabancho esteban.gabancho@gmail.com