Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing space between orcid icon and name in deposit form #468

Closed
fenekku opened this issue Mar 14, 2022 · 4 comments
Closed

Missing space between orcid icon and name in deposit form #468

fenekku opened this issue Mar 14, 2022 · 4 comments
Labels
bug Something isn't working
Projects
Accessibility / UI / UX

Comments

@fenekku
Copy link
Contributor

fenekku commented Mar 14, 2022

Package version (if known): 8.0

Describe the bug

Space missing between orcid icon and name:

orcid_spacing_deposit_page
@fenekku fenekku added the bug Something isn't working label Mar 14, 2022
@lhenze
Copy link
Member

lhenze commented Mar 14, 2022

According to Orcid brand guidelines, the icon must follow the name. WDYT of this. Other ideas?
Screen Shot 2022-03-14 at 5 26 34 PM

@lhenze
Copy link
Member

lhenze commented Apr 20, 2022

Screen Shot 2022-04-20 at 12 23 44 PM

The previously proposed solution would require refactoring and perhaps be fairly involved. Here's an idea for a short-term solution.
https://github.com/inveniosoftware/react-invenio-deposit/compare/master...lhenze:bug/1378-orcid-icon?expand=1

@lhenze lhenze transferred this issue from inveniosoftware/invenio-app-rdm Apr 20, 2022
@kpsherva kpsherva mentioned this issue Apr 25, 2022
Open
@lhenze
Copy link
Member

lhenze commented May 31, 2022

The missing space issue is now resolved. @fenekku, ok to close this?

Screen Shot 2022-05-31 at 7 20 17 AM

@fenekku
Copy link
Contributor Author

fenekku commented May 31, 2022

Yes, I will close this. I made another issue for another ORCID-related ticket: #508. Thanks!

@fenekku fenekku closed this as completed May 31, 2022
Accessibility / UI / UX automation moved this from In progress to Done May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Accessibility / UI / UX
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lhenze @fenekku