Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AccordionField not possible to be folded when the page loads #230

Open
Ducica opened this issue Jan 30, 2024 · 6 comments
Open

AccordionField not possible to be folded when the page loads #230

Ducica opened this issue Jan 30, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@Ducica
Copy link
Contributor

Ducica commented Jan 30, 2024

Package version (if known): 2.8.4

Describe the bug

Since defaultActiveIndex is removed (seems to be recent change), it is no longer possible to control via prop if the accordion will be folded or not when the page loads. The activeIndex is internal component state into which we cannot plug in any way. Normally, we need to keep some accordions open on page load and others folded. This should definitely be programmable via props like it used to be.

Steps to Reproduce

Use the component and try to control the accordion initial state via props.

Expected behavior

Screenshots (if applicable)

Additional context

@Ducica Ducica added the bug Something isn't working label Jan 30, 2024
@mesemus
Copy link

mesemus commented Mar 17, 2024

Pull request that introduced the change: c4e2530

@tmorrell
Copy link

tmorrell commented May 6, 2024

This has been annoying for us as well and would be great to get fixed @Ducica

@Ducica
Copy link
Contributor Author

Ducica commented May 7, 2024

Okay, I can do it, I am not sure if I need to get a go ahead from @ntarocco first?

@tmorrell
Copy link

tmorrell commented May 7, 2024

Anyone is always free to make PRs. When they get merged is another question. Having the ability to customize tab opening again is very much a desired feature, as long as you don't break accessibility.

@Ducica
Copy link
Contributor Author

Ducica commented May 7, 2024

@tmorrell well allrighty then, i'll try to do it in the upcoming days

@Ducica
Copy link
Contributor Author

Ducica commented May 9, 2024

Hello, here is the PR: #239. Please take a look. @ntarocco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants