Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: py.test removal from install requirements #24

Merged
merged 2 commits into from
Sep 3, 2014

Conversation

jirikuncar
Copy link
Member

  • Adds CONTRIBUTING.rst file.

Signed-off-by: Jiri Kuncar <jiri.kuncar@cern.ch>
@tiborsimko
Copy link
Member

  • Please add CONTRIBUTING.rst to MANIFEST.in.
  • Please include it in docs/index.rst in the appropriate "Contributing" section to avoid duplicating this information.
  • Hmm, have you looked at why Travis CI build fails during sphinx doc building? (I can build and test fine locally.)

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 1748810 on jirikuncar:pytest into 9d79630 on inveniosoftware:master.

@jirikuncar
Copy link
Member Author

Please add CONTRIBUTING.rst to MANIFEST.in.

Added *.rst and docs to MANIFEST.in

Please include it in docs/index.rst in the appropriate "Contributing" section to avoid duplicating this information.

Done

Hmm, have you looked at why Travis CI build fails during sphinx doc building? (I can build and test fine locally.)

No clue. Now it should be ok. (https://travis-ci.org/inveniosoftware/workflow/builds/34260823)

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 61fd21b on jirikuncar:pytest into 9d79630 on inveniosoftware:master.

@tiborsimko
Copy link
Member

I see you added AUTHORS in this commit; this is good, but requires some more changes:

  • please add Raja Sripada <raja.sripada@cern.ch> right after Roman; he worked on pickle and friends, see CHANGES.txt
  • the formatting of AUTHORS section is broken, please use list for contributors
  • the CONTRIBUTING section would be logically better placed just before the AUTHORS, i.e. after API, like in our other repositories e.g. http://dictdiffer.readthedocs.org/en/latest/

(WRT last point, I also planned to add LICENSE and CHANGES as well, but that'd be better part of another separate PR)

* Improves also API section.

Signed-off-by: Jiri Kuncar <jiri.kuncar@cern.ch>
@tiborsimko tiborsimko merged commit eb81438 into inveniosoftware-contrib:master Sep 3, 2014
@jirikuncar jirikuncar deleted the pytest branch September 3, 2014 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants