Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Include parameters in search #5576

Open
1 of 2 tasks
wolflu05 opened this issue Sep 20, 2023 · 17 comments
Open
1 of 2 tasks

[FR] Include parameters in search #5576

wolflu05 opened this issue Sep 20, 2023 · 17 comments
Labels
api Relates to the API enhancement This is an suggested enhancement or new feature Platform UI Related to the React based User Interface
Milestone

Comments

@wolflu05
Copy link
Contributor

wolflu05 commented Sep 20, 2023

Please verify that this feature request has NOT been suggested before.

  • I checked and didn't find a similar feature request

Problem statement

I added numbers like GTIN as PartParameters or ManufacturerPartParameter to all of my parts. When using the global search I get zero results because parameters are not included in the global search.

Global search:
image

Suggested solution

Include parameters in the global search

Describe alternatives you've considered

Don't use parameters for searchable numbers, but where else do I put the GTIN then? IPN, SKU and MPN are already used by their numbers.

Examples of other systems

No response

Do you want to develop this?

  • I want to develop this.
@wolflu05 wolflu05 added enhancement This is an suggested enhancement or new feature triage:not-checked Item was not checked by the core team labels Sep 20, 2023
@SchrodingersGat
Copy link
Member

If you can search by parameter, what is the "Result" that is returned? Is it a single parameter, or is it the part that the parameter is assigned to?

@wolflu05
Copy link
Contributor Author

Without thinking about what is difficult to implement, I would say the part showing the parameter would be the best option.

@SchrodingersGat SchrodingersGat added api Relates to the API Platform UI Related to the React based User Interface and removed triage:not-checked Item was not checked by the core team labels Sep 21, 2023
@SchrodingersGat
Copy link
Member

Search integration will also involve significant front-end changes so I think it makese sense to leave this for the new react interface?

@wolflu05
Copy link
Contributor Author

Yes, makes sense. Its not that important for me that I need it now, but I think it would be a good search improvement.

Copy link
Contributor

This issue seems stale. Please react to show this is still important.

@github-actions github-actions bot added the inactive Indicates lack of activity label Nov 21, 2023
@SchrodingersGat
Copy link
Member

Nt stale

@github-actions github-actions bot removed the inactive Indicates lack of activity label Nov 22, 2023
Copy link
Contributor

This issue seems stale. Please react to show this is still important.

@github-actions github-actions bot added the inactive Indicates lack of activity label Jan 22, 2024
@wolflu05
Copy link
Contributor Author

Still active

@github-actions github-actions bot removed the inactive Indicates lack of activity label Jan 23, 2024
Copy link
Contributor

This issue seems stale. Please react to show this is still important.

@github-actions github-actions bot added the inactive Indicates lack of activity label Mar 24, 2024
@wolflu05
Copy link
Contributor Author

Still active

@github-actions github-actions bot removed the inactive Indicates lack of activity label Mar 25, 2024
@ECCOsea
Copy link

ECCOsea commented Apr 12, 2024

May be its not be so relevant but i want to suggest catalog mode. Like on mouser or explanation on screenshot below.
It is will be very convinient for search components via parameters and simultaniously see their locations to fast pickup this and try it in schematics.
Catalogue Mode

@wolflu05
Copy link
Contributor Author

wolflu05 commented Apr 12, 2024

This is not related to this issue. This issue is about including parts with parameter values in the global search (the search where one can find parts, stock location, stock items, mp, sp,, ...).

I have added a screenshot of the global search I meant to the initial PR description.

Regarding your parameters table, this is as far as I can tell already supported by CUI (you need to select the parameter panel manually) and mostly also by PUI. Just the filtering part is missing, but that should be a separate issue.

@wolflu05
Copy link
Contributor Author

Should we add that to the horizont milestone?

@matmair
Copy link
Contributor

matmair commented Apr 12, 2024

sounds reasonable

@wolflu05 wolflu05 added this to the horizon milestone Apr 12, 2024
@SchrodingersGat
Copy link
Member

@ECCOsea note that we already have a "catalog" mode which works very well in the new interface:

https://demo.inventree.org/platform/part/category/5/parameters

image

@ECCOsea
Copy link

ECCOsea commented Apr 15, 2024

@SchrodingersGat wow! Thank you for link! This is very cool solution!!! Where i can leave feedback and suggestions? I want to test and improve this!

@SchrodingersGat
Copy link
Member

Feedback you can leave here, raise any specific issues or new PRs.

If you want to work on this yourself, which would be great, then read these links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Relates to the API enhancement This is an suggested enhancement or new feature Platform UI Related to the React based User Interface
Projects
None yet
Development

No branches or pull requests

4 participants