Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings fix #6904

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Conversation

SchrodingersGat
Copy link
Member

Fix bug in settings.py, exposed by sonarcloud analysis

- Bug fix for statement which had no effect
@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed backport Apply this label to a PR to enable auto-backport action backport-to-0.14.x labels Apr 2, 2024
@SchrodingersGat SchrodingersGat added this to the 0.15.0 milestone Apr 2, 2024
Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit c2ff066
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/660b518206000e0007cdc89b
😎 Deploy Preview https://deploy-preview-6904--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

sonarcloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.9% Duplication on New Code

See analysis details on SonarCloud

@SchrodingersGat SchrodingersGat merged commit cfff6ad into inventree:master Apr 2, 2024
26 checks passed
@SchrodingersGat SchrodingersGat deleted the settings-fix branch April 2, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Apply this label to a PR to enable auto-backport action bug Identifies a bug which needs to be addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant