Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUI] Column Refactoring #7242

Merged
merged 5 commits into from
May 17, 2024

Conversation

SchrodingersGat
Copy link
Member

Some general refactoring for table column defintions.

@SchrodingersGat SchrodingersGat added user interface User interface refactor Platform UI Related to the React based User Interface javascript Pull requests that update Javascript code labels May 16, 2024
@SchrodingersGat SchrodingersGat added this to the 0.16.0 milestone May 16, 2024
Copy link

netlify bot commented May 16, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit c8718b3
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/664694dc0eee3b0008604248
😎 Deploy Preview https://deploy-preview-7242--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 86 (no change from production)
Best Practices: 92 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.08%. Comparing base (2a83c19) to head (c8718b3).

Files Patch % Lines
src/frontend/src/tables/ColumnRenderers.tsx 77.77% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7242      +/-   ##
==========================================
+ Coverage   84.04%   84.08%   +0.04%     
==========================================
  Files        1053     1052       -1     
  Lines       46260    46237      -23     
  Branches     1328     1320       -8     
==========================================
+ Hits        38877    38878       +1     
+ Misses       7056     7026      -30     
- Partials      327      333       +6     
Flag Coverage Δ
pui 64.67% <77.77%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit acb1ec4 into inventree:master May 17, 2024
25 of 26 checks passed
@SchrodingersGat SchrodingersGat deleted the bom-table-fix branch May 17, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code Platform UI Related to the React based User Interface refactor user interface User interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant