Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Aircraft Type, Registration and ICAO are not shown on the live map #98

Closed
PilotFlying99 opened this issue Sep 20, 2023 · 10 comments
Labels
bug Something isn't working

Comments

@PilotFlying99
Copy link

Describe the bug

Good day,

since one of the recents updates oour live map does not show the aircraft registration and ICAO anymore. We did not make any code changes, just updated from API version 0.3.5 to version 0.3.7.

We followed the suggested changes from invernyx/smartcars-3-bugs#184 to make it work in the past.

Suddenly, this stopped working. Any ideas why?

How do you reproduce this bug?

  1. Navigate to the livemap of phpVMS 5

Expected behavior

The aircraft type, registration and ICAO is not being exported to the hphVMS anymore.

Screenshots

error

Operating system

Windows 10 Pro 22H2

Community airline

LH Virtual Group

smartCARS Version

3.0.0

Plugins installed

Chat, Flight Center, Flight Tracking, Logbook, Map, SimBrief

Additional context

The aircraft type, registration and ICAO is not being exported to the hphVMS anymore.

@GenericNerd GenericNerd transferred this issue from invernyx/smartcars-3-bugs Sep 25, 2023
@GenericNerd
Copy link
Member

Transferred to the correct repository

@ifly-leonard
Copy link

I have a similar issue at one of my VAs too! When the pilot has MORE than 1 bid, SC3 fetches the aircraft information from the first bid, despite the flight in the first bid already being complete. I have temporarily curbed this by disabling pilots to have multiple bids, but that's not a permanent solution.

We're on API Version 0.3.7 (phpvms5)

image

@EpicHax7
Copy link

yes having exactly the same issue as mentioned by @ifly-leonard
can u guy look into this please
thank you

@GenericNerd
Copy link
Member

Hey all (@EpicHax7 @ifly-leonard @PilotFlying99). I've update the API on the development branch to 0.3.8 which has hopefully restored this. Let me know whether this resolves it for you!

@GenericNerd GenericNerd added bug Something isn't working question Further information is requested labels Oct 4, 2023
@PilotFlying99
Copy link
Author

@GenericNerd Thank you very much! We moved a step ahead.

However, there is still one issue: the aircraft which is now shown, is the scheduled aircraft, not the actual chosen aircraft inside the smartCARS 3 client.

Bildschirmfoto 2023-10-06 um 21 49 57

@PilotFlying99
Copy link
Author

PilotFlying99 commented Oct 6, 2023

The issue also consists when viewing the PIREP via the admin panel. It shows the scheduled aircraft, not the actual chosen one via the smartCARS 3 client.

zPJnKlwD3rFodE30k-sTRe-jhuwhVQKJYA

@PilotFlying99
Copy link
Author

PilotFlying99 commented Oct 6, 2023

Update: I fixed the issue myself.

You need to change line 32 in /0.3.8/handlers/phpvms5/flights/update.php from:

'aircraft' => $flightDetails['aircraft'], to 'aircraft' => $_POST['aircraft'],

Additionally, you need to change line 61 in /0.3.8/handlers/phpvms5/flights/complete.php from:

'aircraft' => $route['aircraft'], to 'aircraft' => $_POST['aircraft'],

@GenericNerd
Copy link
Member

I’ll reopen this issue as there is a documented fix that I’ll implement in this version

@GenericNerd
Copy link
Member

Can you all try the 0.3.9 branch and let me know if that solution works for you?

@GenericNerd GenericNerd removed the question Further information is requested label Jan 26, 2024
@GenericNerd
Copy link
Member

This issue is now stale. If this is still happening, please open up a new issue and refer to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants