Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pfdetect queue: Do not start if pfdetect is not started #1593

Closed
dwlfrth opened this issue Jun 30, 2016 · 4 comments
Closed

pfdetect queue: Do not start if pfdetect is not started #1593

dwlfrth opened this issue Jun 30, 2016 · 4 comments

Comments

@dwlfrth
Copy link
Contributor

dwlfrth commented Jun 30, 2016

Do we really need to spawn a (or whatever configured number of) pfqueue for pfdetect if pfdetect is not running ?

@dwlfrth dwlfrth added this to the PacketFence-6.2 milestone Jun 30, 2016
@julsemaan
Copy link
Collaborator

+1

@jrouzierinverse
Copy link
Member

This can be done however if pfdetect goes from disabled -> enabled or enabled -> disabled, pfqueue must be restarted to ensure the pfdetect worker is started or stopped.
If that is ok then yes this can be done quickly.
If not then I would need to add some type of polling to the pfqueue master to pickup on configuration changes.

@julsemaan
Copy link
Collaborator

I'd say it would be OK for pfqueue to be restarted, it should use the isManaged sub of pfdetect since it contains custom logic. And we need to document the pfqueue restart in the admin guide in places where we enable pfdetect

@dwlfrth
Copy link
Contributor Author

dwlfrth commented Jul 22, 2016

As @julsemaan says...
Also, on pfdetect parsers configuration, pfdetect needs to be restarted...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants