New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

captive-portal: i18n label for dynamic fields #1911

Closed

dwlfrth opened this issue Dec 16, 2016 · 1 comment

Assignees

Labels

Milestone

PacketFence-7.0

Contributor

dwlfrth commented Dec 16, 2016

Dynamically created fields on the captive-portal do not have the correct translation "label" in .po files due to first capitalized letter.
https://github.com/inverse-inc/packetfence/blob/packetfence-6.4.0/html/captive-portal/lib/captiveportal/PacketFence/Form/Authentication.pm#L34

Per example, that would make the "telephone" label "Telephone" and in .po file, msgid is "telephone" and not "Telephone"
https://github.com/inverse-inc/packetfence/blob/packetfence-6.4.0/conf/locale/en/LC_MESSAGES/packetfence.po#L963

dwlfrth added the Type: Bug label

dwlfrth added this to the PacketFence-6.5 milestone

dwlfrth self-assigned this

extrafu modified the milestones: PacketFence-6.6, PacketFence-6.5

dwlfrth modified the milestones: PacketFence-6.6, PacketFence-7.0

Contributor Author

dwlfrth commented Apr 10, 2017 •

edited

Fixed with 6440882
Reopen if needed.

dwlfrth closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment