Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node.pm #3963

Merged
merged 2 commits into from Mar 4, 2019
Merged

Update node.pm #3963

merged 2 commits into from Mar 4, 2019

Conversation

elijahnyp
Copy link
Contributor

Description

allow packet fence to actually scan on registration/post registration

Impacts

registration process/vulnerability scanning

Delete branch after merge

YES

Checklist

(REQUIRED) - [yes, no or n/a]

  • [N/A ] Document the feature
  • [ N/A] Add unit tests
  • [ N/A] Add acceptance tests (TestLink)

Bug Fixes

  • fixes on-registration scanning

@elijahnyp
Update node.pm
51c8af1 
typo causing on-registration scan to fail should be _registration but was registration
@CLAassistant
Copy link

CLAassistant commented Jan 27, 2019 •
edited

CLA assistant check
All committers have signed the CLA.

@julsemaan
Copy link
Collaborator

This looks totally good to me, please just sign the CLA and I'll merge

@julsemaan julsemaan added this to the +1 (patch release) milestone Jan 28, 2019
@julsemaan julsemaan self-assigned this Jan 28, 2019
@fdurand fdurand merged commit 82b7cdd into inverse-inc:devel Mar 4, 2019
fdurand added a commit that referenced this pull request Mar 4, 2019
@fdurand
NEWS entry for #3963
c729b76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@julsemaan julsemaan

Labels
None yet
Projects
None yet
Milestone
+1 (patch release)
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@elijahnyp @CLAassistant @julsemaan @fdurand