Added a new trigger on node maintenance task #4948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nqb
suggested changes
Dec 19, 2019
lib/pf/node.pm
Outdated
| 'tid' => 'node_maintenance', | ||
| 'type' => 'internal', | ||
| ); | ||
| $apiclient->call('trigger_violation', %violation_data); |
There was a problem hiding this comment.
trigger_violation and %violation_data need to be renamed to security_event.
fdurand
force-pushed
the
feature/trigger_on_maintenance
branch
from
b5120b2
to
b5d1927
Compare
|
@nqb, take another look and merge |
nqb
reviewed
Apr 2, 2020
lib/pf/node.pm
Outdated
| 'tid' => 'node_maintenance', | ||
| 'type' => 'internal', | ||
| ); | ||
| $apiclient->call('security_event', %security_event); |
There was a problem hiding this comment.
Suggested change
| $apiclient->call('security_event', %security_event); | |
| $apiclient->notify('trigger_security_event', %security_event); |
There was a problem hiding this comment.
Make following change and I will merge.
|
BUMP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a security event trigger on node maintenance task
Impacts
pfmon
Delete branch after merge
YES
Checklist
NEWS file entries
Enhancements