feature/remove_currently_at #5121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We will need to upgrade documentation (Upgrade guide and others) to remove |
|
done |
jrouzierinverse
added
Status: In progress
Status: For review
and removed
Status: For tracking
Status: In progress
labels
|
@nqb Just merge it if all is fine. |
|
@jrouzierinverse: could you add upgrade instructions and/or write a script that delete old currently-at file for users doing upgrades ? I updated our post-upgrade template added at end of upgrade guide to remove reference to currently-at file in Database schema section. |
|
@nqb I've added the toggle button to enable/disable the Configurator. |
|
Thanks @cgx, I will wait upgrade instructions or script migration from @jrouzierinverse now. |
|
Done |
nqb
added a commit
that referenced
this pull request
Mar 2, 2020
|
I add another part to your upgrade notes in Upgrade guide. Let me know if it's fine for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the need for the currently_at file
Impacts
The configurator
NEWS file entries
Enhancements
UPGRADE file entries
The file /usr/local/pf/conf/currently-at is no longer needed it can be removed.
rm -rf /usr/local/pf/conf/currently-at