Fix/5476

[julsemaan]

Description

Adjustments for SAML + OAuth for the portal modules

Impacts

SAML + OAuth portal modules

Issue

fixes #5476

Delete branch after merge

YES

Checklist

(REQUIRED) - [yes, no or n/a]

• Document the feature
• Add unit tests
• Add acceptance tests (TestLink)

NEWS file entries

Enhancements

• Adjust the settings in the admin for the SAML and OAuth portal modules

Bug Fixes

• Honor the AUP setting of the SAML portal module

[nqb]

• aup_template and landing_template fields are missing when editing an SAML portal module.
  Not sure if it's expected.

• If I set with_aup=0 on a SAML portal module, AUP is always displayed. Tested with

[saml_portal]
source_id=saml
actions=
fields_to_save=
custom_fields=
description=saml_portal
with_aup=0
signup_template=signin.html
pid_field=email
aup_template=aup_text.html
type=Authentication::SAML

[nqb]

Hello @julsemaan,

could you provide me your feedback ?

Thanks.

[julsemaan]

I tested it and it worked fine on my end before your comment.

I will have to revisit this and see where is the issue but it did work when I pushed the code

I'll also check to add the missing fields in the admin

[nqb]

Regarding issue with with_aup=0, I double checked and was not able to make it working.

[julsemaan]

@nqb, the with_aup is properly honored on my end

conf:

[custom-saml]
source_id=maml
actions=
fields_to_save=
custom_fields=
description=custom-saml
with_aup=0
signup_template=signin.html
pid_field=email
aup_template=aup_text.html
type=Authentication::SAML

[nqb]

I will test again.

[nqb]

It finally worked without any change on my side (except a reboot). I will test your new changes.

[nqb]

Unless I'm missing something, there is no need for this code here.

This code add an invisible button below "I accept the terms", you can click on it and you got "You must accept the terms and conditions"

[julsemaan]

That "I accept the terms" needs a target to submit the form

You can try to remove it and we'll see if it still works but AFAIK this is needed

[nqb]

You're right.