Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web admin: high-availability setting is not display correctly when editing an interface #5963

Closed
nqb opened this issue Nov 3, 2020 · 5 comments · Fixed by #5964
Closed

Comments

@nqb
Copy link
Contributor

nqb commented Nov 3, 2020

Describe the bug
When you edit an interface with type=high-availability, web admin doesn't display correct setting.

To Reproduce
Steps to reproduce the behavior:

  1. Configure your management interface as high-availability
  2. Save
  3. Leave current view
    Capture d’écran de 2020-11-03 11-26-21

=> high-availability appears as an additional daemon which is wrong

  1. Click on your interface

Capture d’écran de 2020-11-03 11-27-55

=> high-availability appears as an additional daemon but not as a setting enabled.

Expected behavior
high-availability should:

  • not appear as an additional daemon
  • appear as enabled when that is the case

Additional context
pf.conf after I enabled high-availability on my interface:

[interface eth1]
ip=172.17.17.10
type=management,portal,high-availability
mask=255.255.255.0

When I try to display my interface (step 4), I see following return from API:

    "item": {
      "additional_listening_daemons": [
        "portal",
        "high-availability"
      ],
      "address": "172.17.17.10/24",
[..]
      "high_availability": 1,
[..]
@nqb nqb added the Type: Bug label Nov 3, 2020
@nqb
Copy link
Contributor Author

nqb commented Nov 3, 2020

Additional note: on a setup with no portal daemon listening on management interface, high-availability appears as disabled and doesn't appear as additional daemon.

@nqb
Copy link
Contributor Author

nqb commented Nov 3, 2020

@jrouzierinverse, I opened #5964 and push a fix to see if frontend can't display correctly value return by frontend.

Could you check on your side why high-availability appears as additional daemon and push to fix/5963 ?

Thanks

@rcmcdonald91
Copy link

#5680 I reported this back in July.

@nqb
Copy link
Contributor Author

nqb commented Nov 3, 2020

Thanks @theonemcdonald

@nqb nqb closed this as completed in #5964 Dec 8, 2020
@nqb
Copy link
Contributor Author

nqb commented Dec 9, 2020

Fix pushed to maintenance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants