Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting a user doesn't reevaluate the access of the devices it owned #6084

Open
julsemaan opened this issue Jan 8, 2021 · 2 comments
Open

Comments

@julsemaan
Copy link
Collaborator

Describe the bug
When you delete a user via the admin, then the nodes he owns are unregistered but their access isn't reevaluated which leaves devices online although they are now unregistered

To Reproduce

  1. Register a device under any user
  2. Go in Users->click on the user details->Hit delete
  3. Device is unreg but no access reevaluation was done

Expected behavior
After unregistering the device, access reevaluation should be performed

@jrouzierinverse
Copy link
Member

This scenario cannot happen as explained.
When a user is deleted all their nodes are deleted from the database.
https://github.com/inverse-inc/packetfence/blob/devel/db/pf-schema-10.2.0.sql#L191
Obviously, we still need to unreg and reevaluate before the deletion.
Should we warn that the user has registered nodes on the system before letting them be deleted?

@julsemaan
Copy link
Collaborator Author

We can perform a unassignement of the nodes of the user (put them back on the default user), block the deletion or do the access reevaluation.

Any of the 3 are fine with me, if they are unassigned, just make sure proper warnings are in place so the user understands what is about to happen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants