Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/6367 #6379

Merged
merged 4 commits into from
Jun 3, 2021
Merged

fix/6367 #6379

merged 4 commits into from
Jun 3, 2021

Conversation

jrouzierinverse
Copy link
Member

Description

Support switch_group for in advanced filters.

NEWS file entries

Enhancements

Bug Fixes

  • Support switch_group for in advanced filters.

Issue

fixes #6367

Delete branch after merge

NO

Checklist

  • Document the feature
  • Add unit tests
  • Add acceptance tests (TestLink)

@nqb nqb self-assigned this May 31, 2021
@nqb nqb self-requested a review May 31, 2021 05:51
@nqb
Copy link
Contributor

nqb commented May 31, 2021

Failure during Perl unit tests: https://gitlab.com/inverse-inc/packetfence/-/jobs/1305271863#L749

t/unittest/condition/switch_group.t Outdated Show resolved Hide resolved
t/unittest/condition/switch_group.t Outdated Show resolved Hide resolved
@nqb
Copy link
Contributor

nqb commented Jun 3, 2021

As discussed with @jrouzierinverse, error in unit tests was caused by a false positive on pipeline. I rerun a pipeline on that branch correctly: all tests passed.

I will now test this fix on a 10.3 setup.

@nqb
Copy link
Contributor

nqb commented Jun 3, 2021

Work as expected.

@nqb nqb self-requested a review June 3, 2021 08:26
@nqb nqb merged commit d4001d4 into devel Jun 3, 2021
nqb added a commit that referenced this pull request Jun 3, 2021
@satkunas satkunas deleted the fix/6367 branch May 15, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

connection profile: switch_group advanced filter doesn't work
2 participants