Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/venom local dev #6711

Merged
merged 21 commits into from
Nov 25, 2021
Merged

Feature/venom local dev #6711

merged 21 commits into from
Nov 25, 2021

Conversation

nqb
Copy link
Contributor

@nqb nqb commented Nov 19, 2021

Description

Simplify local development of Venom tests on runners shared by the team.

  • Dedicate subnets and IP addresses for each member of the team
  • Create new local VMs (pf*localdev)
  • Remove requirement on CI_PIPELINE_ID: allow to install packetfence packages from PacketFence repositories
  • Manage secrets per user (in Ansible inventory)
  • Simplify make usage to start/stop/clean/provision/run tests
  • Automatically sync Venom directory with /usr/local/pf/t/venom on VM with packetfence-test

Impacts

Tests

Delete branch after merge

YES

Checklist

(REQUIRED) - [yes, no or n/a]

  • Document the feature

NEWS entry

Enhancements

  • Simplify local development of Venom tests

@nqb nqb force-pushed the feature/venom-local-dev branch 2 times, most recently from e883843 to 6a84e1b Compare November 19, 2021 09:45
@nqb nqb force-pushed the feature/venom-local-dev branch 6 times, most recently from e56ea61 to 24da6c3 Compare November 24, 2021 11:07
@nqb nqb force-pushed the feature/venom-local-dev branch 4 times, most recently from 771c72f to 30f3c8d Compare November 24, 2021 22:38
@nqb nqb force-pushed the feature/venom-local-dev branch 2 times, most recently from e2807b0 to 19290e2 Compare November 25, 2021 06:56
@nqb nqb force-pushed the feature/venom-local-dev branch 2 times, most recently from 362bad0 to f8a031d Compare November 25, 2021 07:29
and allow to shutdown all VM without errors using make halt
@nqb nqb requested a review from JeGoi November 25, 2021 08:42
@nqb nqb added this to the PacketFence-11.2 milestone Nov 25, 2021
@nqb
Copy link
Contributor Author

nqb commented Nov 25, 2021

Pipeline work as expected. Ready to merge on my side.

Copy link
Contributor

@JeGoi JeGoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@nqb nqb merged commit 827470b into devel Nov 25, 2021
nqb added a commit that referenced this pull request Nov 25, 2021
nqb added a commit that referenced this pull request Nov 25, 2021
nqb added a commit that referenced this pull request Nov 25, 2021
nqb added a commit that referenced this pull request Nov 25, 2021
nqb added a commit that referenced this pull request Nov 25, 2021
nqb added a commit that referenced this pull request Nov 25, 2021
nqb referenced this pull request Nov 25, 2021
necesseray for localdev when we update requirements.yml
nqb added a commit that referenced this pull request Nov 26, 2021
nqb added a commit that referenced this pull request Nov 26, 2021
nqb added a commit that referenced this pull request Nov 26, 2021
nqb added a commit that referenced this pull request Nov 30, 2021
nqb pushed a commit that referenced this pull request Nov 30, 2021
nqb pushed a commit that referenced this pull request Nov 30, 2021
@JeGoi JeGoi deleted the feature/venom-local-dev branch May 4, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants