Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test suites for inlinel2 and inlinel3 #6769

Merged
merged 42 commits into from
Jan 6, 2022
Merged

Test suites for inlinel2 and inlinel3 #6769

merged 42 commits into from
Jan 6, 2022

Conversation

fdurand
Copy link
Member

@fdurand fdurand commented Dec 13, 2021

Description

Cover test for inlinel3 and inlinel2

Impacts

Tests

Delete branch after merge

YES

@fdurand fdurand added this to the PacketFence-11.2 milestone Dec 13, 2021
@fdurand fdurand requested review from nqb and JeGoi December 13, 2021 20:07
@extrafu extrafu changed the title Test suites for inlinel3 and inlinel3 Test suites for inlinel2 and inlinel3 Dec 14, 2021
nqb
nqb suggested changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@nqb nqb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put some single comment during review, I will add here general comments related to the whole test suites:

  1. Could you rebase on devel ?
  2. We need to have variables for each test suite defined in vars/all.yml
  3. When using API calls your JSON payloads contain:
    • default values: could you remove it ?
    • sometimes id key which is not necessary if already present in URL
  4. Could you create a diagram for inline L2 ?
  5. On diagrams, could you mention where is the PacketFence server to clarify ?
  6. [/] I run that scenario on a runner and both test suites failed at Test-if-the-device-is-in-the-ipset-role-ID-2-Guest-role
  7. [/] I and @JeGoi will move some test cases into executor to avoid duplication between both test suites
    => will be done later on a specific PR.

I will add another comment later which more specific to the logic of the scenario

.gitlab-ci.yml Outdated Show resolved Hide resolved
.gitlab-ci.yml Outdated Show resolved Hide resolved
t/venom/scenarios/inline/playbooks/configure.yml Outdated Show resolved Hide resolved
t/venom/test_suites/inline/l3/10_setup_packetfence.yml Outdated Show resolved Hide resolved
t/venom/test_suites/inline/l3/25_local_user_authentication.yml Outdated Show resolved Hide resolved
t/venom/test_suites/inline/l3/30_trigger_violation.yml Outdated Show resolved Hide resolved
t/venom/test_suites/inline/l3/teardown/05_setup_packetfence.yml Outdated Show resolved Hide resolved
t/venom/test_suites/inline/l3/teardown/05_setup_packetfence.yml Outdated Show resolved Hide resolved
t/venom/test_suites/inline/l2/05_setup_packetfence.yml Show resolved Hide resolved
t/venom/test_suites/inline/l2/teardown/05_setup_packetfence.yml Outdated Show resolved Hide resolved
nqb
nqb suggested changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@nqb nqb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I suggest to rename test cases without any spaces and uppercase letters because it create long variables (when you want to reuse output from a test case)

EDIT: DONE

nqb
nqb suggested changes Dec 19, 2021
View reviewed changes
Copy link
Contributor

@nqb nqb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, inline test suites don't require other VM than pf VM so they could be part of unit_tests scenario to speed tests.

EDIT: DONE

nqb
nqb suggested changes Dec 19, 2021
View reviewed changes
Copy link
Contributor

@nqb nqb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also we should create a connection profile with an inline filter.

EDIT: dependency to default connection profile in /root/register_node so we keep things like this for now.

@nqb nqb force-pushed the test/inlinel3 branch 2 times, most recently from afbb74d to 253457c Compare December 24, 2021 08:38
nqb
nqb suggested changes Jan 3, 2022
View reviewed changes
t/venom/vars/all.yml Outdated Show resolved Hide resolved
JeGoi
JeGoi reviewed Jan 5, 2022
View reviewed changes
t/venom/scenarios/inline/playbooks/configure.yml Outdated Show resolved Hide resolved
t/venom/vars/all.yml Outdated Show resolved Hide resolved
fdurand and others added 25 commits January 6, 2022 12:09
@fdurand @nqb
Set eth0 as snat interface
1e30357
@JeGoi @nqb
[Venom] Inline test: add inline l3 and inline2
7765f47
@JeGoi @nqb
[Venom] Inline test: Add install qemu-kvm for el8
def1303
@fdurand @nqb
Removed duplicated step
3ae853a
@JeGoi @nqb
[Venom] Inline test: add inline in ci
6bbde03
@fdurand @nqb
Added TESTSUITE.md for l2 and l3
76d354d
@fdurand @nqb
Added network diagram for inline l3 test
c03c3e6
@fdurand @nqb
Renamed all the test cases
c885581
@fdurand @nqb
Updated Diagram
ede5a47
@fdurand @nqb
Added Diagram.png for inline l2
db6e40b
@fdurand @nqb
Renamed files
b86f12f
@fdurand @nqb
Enabled netflow
d24fc4a
@fdurand @nqb
Fixes tests
3070031
@nqb
update get_login_token variable
3e507c1
@nqb
run inline tests as part of unit_tests scenario
a168f54
@JeGoi @nqb
[Venom] Inline: Add variables for l3, Create symlink from qemu-kvm to…
4b7249a 
… qemu-system-x86_64
@JeGoi @nqb
[Venom] Unit tests: change inline position
a527f40
@JeGoi @nqb
[Venom] inline l2 and l3 add variables
63dd16d
@JeGoi @nqb
[Venom] Inline l2 l3: add variables
c9870ae
@nqb
Create a dedicated scenario to avoid issue with Perl unit tests
6a56d11 
This reverts commit 445b4dc.
@JeGoi @nqb
[Venom] Inline add warning for hard coded variables
b059f80
@JeGoi @nqb
[Venom] inline l2 change variable name for l2
8782438
@JeGoi @nqb
[Venom] Inline: remove inline for release test only
9642491
@JeGoi @nqb
[Venom] Inline: add back the symlink for EL8 remove by #62c1500537ecd…
984c367 
…cdec99e1ce4d1e9b72a441ec58a
@nqb
use dedicated configurator test suite
b3d565d 
We don't configure anymore reg and iso interfaces because they are not
used in this scenario. On top of that, PacketFence removes IP on this
interfaces when we start to configure inline interfaces using API
@nqb
cleanup before merge
0cfebe0 
put back cli login vars removed by bad rebase
@nqb nqb merged commit 7346269 into devel Jan 6, 2022
@nqb nqb deleted the test/inlinel3 branch January 6, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nqb nqb nqb requested changes

@JeGoi JeGoi JeGoi left review comments

Assignees
No one assigned
Labels
Priority: Medium Status: Tested and works Type: Feature / Enhancement
Projects
None yet
Milestone
PacketFence-11.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fdurand @nqb @JeGoi