Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/venom 1.0.0 #6775

Merged
merged 31 commits into from Dec 23, 2021
Merged

Feature/venom 1.0.0 #6775

merged 31 commits into from Dec 23, 2021

Conversation

nqb
Copy link
Contributor

@nqb nqb commented Dec 15, 2021 •
edited

Description

  • Upgrade Venom to 1.0.0
  • Refactor Venom code to use more executors

Impacts

Tests

Delete branch after merge

YES

@nqb nqb mentioned this pull request Dec 18, 2021
Merged
@nqb nqb self-assigned this Dec 19, 2021
@nqb
Copy link
Contributor Author

nqb commented Dec 21, 2021

As mentioned on ovh/venom#470, now we need to sort test suites before calling venom run when we pass a directory as an argument.

Some workarounds added in #6573 can also be removed with Venom 1.0.0. Could be a good opportunity.

nqb
nqb commented Dec 21, 2021
View reviewed changes
t/venom/lib/customC.yml Outdated Show resolved Hide resolved
nqb
nqb commented Dec 22, 2021
View reviewed changes
t/venom/test_suites/test_venom/15_testcBcA.yml Outdated Show resolved Hide resolved
t/venom/test_suites/test_venom/20_testVenom.yml Outdated Show resolved Hide resolved
t/venom/test_suites/test_venom/20_testVenom.yml Outdated Show resolved Hide resolved
@nqb
Copy link
Contributor Author

nqb commented Dec 22, 2021

@JeGoi, this PR should be ready to merged.

I'm running a pipeline to be sure we don't miss anything.

The only remaining thing I see is the new custom executors you want to use to call Venom on other hosts. I think we can do that later.

@nqb
Copy link
Contributor Author

nqb commented Dec 22, 2021

New pipeline after a fix: https://gitlab.com/inverse-inc/packetfence/-/pipelines/434779376

@JeGoi @nqb
[Venom] Change Venom version to 1.0.0
c6dc415
@JeGoi @nqb
Add test for multi executor
e89555d
@JeGoi @nqb
[Venom] Add initial override
7b4901c
@JeGoi @nqb
[Venom] Fix issue with customB
251f19c
@JeGoi @nqb
[Venom] Fix issue with customB A and the testcases
7805d72
@JeGoi @nqb
[Venom] add executor in executor for delete_node
b9e2e3d
@JeGoi @nqb
[Venom] Add delete with executors in executors
44aff17
@JeGoi @nqb
[Venom] Add node cleanup as executors
b3051d0
@JeGoi @nqb
[Venom] Add test_venom and customD example
5119809
@JeGoi @nqb
[Venom] v1.0.0 Add executors
fb57ad6
@JeGoi @nqb
[Venom] Upgrade Venom version
1744197
@JeGoi @nqb
[Venom] Test how to share value between results
921df5b
@JeGoi @nqb
[Venom] tests on extrating var from multiple tests
00a7da4
@JeGoi @nqb
[Venom] Test multisuite: extract from suite
ffc6db0
@JeGoi @nqb
[Venom] export data from multisteps
2e74298
@JeGoi @nqb
[Venom] add test to extract var from multisteps example with venom
1dcd51a
@JeGoi @nqb
[Venom] Add failling test to extract data from multisteps
5e95630
@nqb nqb force-pushed the feature/venom-1.0.0 branch 2 times, most recently from 22ef448 to 5fb60da Compare December 22, 2021 13:22
JeGoi
JeGoi approved these changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@JeGoi JeGoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@nqb nqb merged commit 280f23a into devel Dec 23, 2021
@nqb nqb deleted the feature/venom-1.0.0 branch December 23, 2021 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeGoi JeGoi JeGoi approved these changes

Assignees

@nqb nqb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nqb @JeGoi