Hide download and email if the certificate has been signed by scep request

[fdurand]

Description

Hide download and email if the certificate has been signed by scep request

Impacts

PKI

Delete branch after merge

YES

Checklist

• Document the feature
• Add unit tests
• Add acceptance tests (TestLink)

NEWS file entries

Enhancements

• Hide download and email for a certificate that has been signed by a scep request

[nqb]

1. Do we really want to prevent download of SCEP certificates from web admin ?

IMHO, we should allow admin users to download SCEP certificates from web admin because web admin doesn't display all informations of certificates (OCSP URL, key usage, etc.) and if you need these informations, you will have to look into DB.

Certificates generated through SCEP are stored in DB without private keys so it's not a problem. Perhaps we can have a "Copy Certificate" button like we have for CA certificates.

2. Download button is still available when you click on a SCEP certificate

[fdurand]

Just added a way to download the public key.
Also you need to recompile the pki in order to have the Download button removed from the admin gui.

[nqb]

• Existing SCEP certs will have a wrong value of scep field in DB. We need to update existing SCEP certs if we are able to distinguish them but I'm not sure it's possible.

[nqb]

• Existing SCEP certs will have a wrong value of scep field in DB. We need to update existing SCEP certs if we are able to distinguish them but I'm not sure it's possible.

I don't see an automated way to identify SCEP certificate in DB before.

EDIT: it means that "Download" button will be available for old SCEP certificates which can lead to confusion.

EDIT: fixed by 7153f05

[nqb]

Just did new tests:

1. Download button is still available for SCEP certificates when you click on a SCEP certificate (not on the listing, only "Copy certificate")
2. SCEP filter doesn't work:
   

=> I expect to be able to select SCEP

@satkunas, could you take a look ?

[satkunas]

Just did new tests:

1. Download button is still available for SCEP certificates when you click on a SCEP certificate (not on the listing, only "Copy certificate")
2. SCEP filter doesn't work:
   

=> I expect to be able to select SCEP

@satkunas, could you take a look ?

@nqb the scep column has been pinned to ensure that the scep column is returned with each item in order to show/hide the download/email buttons. If this column is not showing up you'll need to clear your pkiCerts::defaultSearch preference.

[nqb]

Work as expected after I remove my preferences and clean my web browser cache.