Test suite Feature/venom cli login tests #6783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nqb
suggested changes
Dec 18, 2021
There was a problem hiding this comment.
Some general notes:
- We are not testing CLI login for Read and Write access, only Write access
- We are not testing CLI login against a real switch but using
radclienton a default switch already created - There is no connection profile created to match on
CLI-Access - We don't validate that a user in local DB can authenticate on the switch. Could be easy to do using a connection profile with an admin account and a local source
- Could you remove useless JSON payload when it's not necessary ?
t/venom/test_suites/cli-login-radius/teardown/00_clean_pf_config.yml
Outdated
Show resolved
Hide resolved
nqb
reviewed
Dec 19, 2021
There was a problem hiding this comment.
At the moment, cli_login test suite doesn't require other VM than pf VM so it could be part of unit_tests scenario to speed tests.
However, at some point, we may want to test CLI login with an AD source so in that case, we will have to boot ad VM and certainly create a dedicated scenario.
nqb
reviewed
Dec 19, 2021
JeGoi
force-pushed
the
feature/venom-cli-login-tests
branch
from
5fa3996
to
1c47ff0
Compare
nqb
force-pushed
the
feature/venom-cli-login-tests
branch
2 times, most recently
from
4d7f533
to
066c23f
Compare
|
Pipeline to test: https://gitlab.com/inverse-inc/packetfence/-/pipelines/435898927 |
|
Hum, it fails but not on the configurator, not the test itself |
Add systemc ctl vor venom 1.0.0
Co-authored-by: Nicolas Quiniou-Briand <nquiniou@akamai.com>
add get_login_token in executor
add get_login_token in executor
Comment assertion (to be validated)
move to variables delete extra
nqb
force-pushed
the
feature/venom-cli-login-tests
branch
from
1455dc2
to
b571482
Compare
|
I tested locally two scenarios and they work as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cover test for cli radius test
Impacts
Venom tests
Delete branch after merge
YES