Feature/venom fingerbank proxy

[julsemaan]

Description

Test the Fingerbank proxy feature in venom

Impacts

Venom tests

Delete branch after merge

YES

[julsemaan]

One thing I'm wondering is should this be part of the configurator scenario?

Currently, its in its own scenario

[julsemaan]

I ran this successfully on runner2 but a pipeline is currently running to assess it works in the official CI environment: https://gitlab.com/inverse-inc/packetfence/-/pipelines/433611476

[nqb]

One thing I'm wondering is should this be part of the configurator scenario?

No, this scenario is specific and only used for the release.

IMHO, it's better to have a dedicated scenario because we boot an additional VM (linux02 here). I suggest to rename your scenario to something more generic related to external services provided by other VM. We will likely reused that scenario to add more tests which cover integration like syslog forwarding, RADIUS, etc.

[nqb]

• For test cases name, could you use something like name_of_my_testcase like get_login_token in place of sentences with spaces ?
• Could you add a TESTSUITE.md in fingerbank_proxy which describe logic of the test (with custom iptables rules, test can be run offline, etc.). You can find an example here.
• An improvement could be to create a new test suite like configurator_proxy to configure Fingerbank proxy at this step.

[julsemaan]

I've addressed most of the comments except the job name

@nqb, in your opinion, how should we name the scenario that is proxy centric (or linux02 centric)?

And do we rename the scenario, make entry and gitlab entry ? or just the make+gitlab entry and run multiple scenarios in that make entry?

[nqb]

@nqb, in your opinion, how should we name the scenario that is proxy centric (or linux02 centric)?

I would suggest something related to external integrations (nothing prevent us to boot ad VM later) . external_integrations as scenario name looks good to me. You need to rename gitlab entry, Makefile entry and name of directory into scenarios directory. You can keep your test suites as is.

[julsemaan]

New pipeline with adjustments: https://gitlab.com/inverse-inc/packetfence/-/pipelines/434354693

Now we just need to state on if the strategy for testing the Fingerbank connectivity is acceptable or not

[nqb]

@julsemaan, thanks for your adjustments.

I think we are good to merge based on answers you provided related to Fingerbank Connectivity.