allow to manage devices (unregister) when reaching max nodes #6860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fdurand, if you have time to review this for 11.2, lets do it, otherwise we bump to 11.3 |
extrafu
reviewed
Jan 31, 2022
| @@ -138,6 +138,11 @@ | |||
| :text="$i18n.t('Under most circumstances we can redirect the user to the URL he originally intended to visit. However, you may prefer to force the captive portal to redirect the user to the redirection URL.')" | |||
| /> | |||
|
|
|||
| <form-group-show-manage-devices-on-max-nodes namespace="show_manage_devices_on_max_nodes" | |||
| :column-label="$i18n.t('Show manage devices options when user reaches max nodes')" | |||
| :text="$i18n.t('When the user reaches the maximum amount of nodes for his username, enabling this will display an option in the portal to access the status page to manage/unregister devices.')" | |||
There was a problem hiding this comment.
When the user reaches the maximum amount of nodes for his username => When the user reaches the maximum amount of registered nodes associated with his or her username
There was a problem hiding this comment.
What about non binary?
fdurand
reviewed
Feb 1, 2022
| @@ -244,6 +244,11 @@ sub apply_new_node_info { | |||
| my ($self) = @_; | |||
| get_logger->debug(sub { use Data::Dumper; "Applying new node_info to user ".Dumper($self->new_node_info)}); | |||
|
|
|||
| if(pf::node::is_max_reg_nodes_reached($self->current_mac, $self->new_node_info->{pid}, $self->new_node_info->{category})) { | |||
| $self->render("max-nodes-reached.html", { show_manage_devices => $self->app->profile->showManageDevicesOnMaxNodes }); | |||
There was a problem hiding this comment.
It looks that max-nodes-reached.html is missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
allow to manage devices (unregister) when reaching max nodes
Impacts
Captive portal
Delete branch after merge
YES
NEWS file entries
New Features