Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
(fix) we now return all cards when we receive an empty addressbook-qu…
…ery REPORT
- Loading branch information
Showing
3 changed files
with
7 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2c72307
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick response!
2c72307
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to only return cards which have an email address?
2c72307
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposed change from "." to "%" resolved issue I raised in my previous comment. Taken from http://sogo.nu/bugs/view.php?id=3373
2c72307
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the same issue as kwirk, only contacts with an email address are returned after doing a reload or using the search.
I first noticed when the contacts synced on my phone via DAVDroid are much less than they should be. So I reloaded the contacts in webmail and bam, most were gone. After a sudden panic I realized I could restore them from backup. After doing so I still seemed to lose them, but only after a reload.
After changing the @"." to @"%" as kwirk suggests, it makes no difference for me, still broken. I also use postgresql. But in a way I'm glad it's not DAVDroid at fault, and it should be fixable fairly easily. I've been concerned that I wouldn't have reliable open source CalDAV/CardDAV sync tool for android, after working well for so long. It disturbs me that as soon as it got mature, they swapped the engine out and it breaks sync with SOGo.
I'll try to patch it myself and report back.
2c72307
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's interesting is that when I apply the above patch (with the @".") to my big production installation that's still on 2.2.14, I don't have the problem. So, there must be another change elsewhere between 2.2.14 and 2.3.6 that has caused this issue.
2c72307
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correction to my last post. The webmail shows all my contacts in 2.2.14, but the DAVDroid sync still only shows contacts with email addresses.
2c72307
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well it seems I'm confusing myself and probably anyone reading my comments. There seem to be more than one bug. The first is the sync issue with DAVDroid. The second is the webmail "Address Book" issue whereby contacts are missing after a "Reload". It just happens that in both cases only contacts with emails are shown.
So I can confirm kwirk's suggestion of changing "." to "%" fixes the sync done on a regular address book by DAVDroid, on both 2.2.14 and 2.3.6. However, the same change breaks Group Directory (Corporate Directory) syncing by DAVDroid.
So, it seems we need a better fix altogether, and there's a new bug with the webmail address book too.
2c72307
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I found a complete solution for the DAVDroid (CardDav) sync issue. See the following PR: #187