fix(mail): don't lowercase href/action/formaction attribute value

Fixes #5434
Alinto · Nov 26, 2021 · c4bb0de · c4bb0de
1 parent d484c2b
commit c4bb0de
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/UI/MailPartViewers/UIxMailPartHTMLViewer.m b/UI/MailPartViewers/UIxMailPartHTMLViewer.m
@@ -446,7 +446,7 @@ - (void) startElement: (NSString *) _localName
            attributes: (id <SaxAttributes>) _attributes
 {
   unsigned int count, max;
-  NSString *name, *value, *cid, *lowerName;
+  NSString *name, *value, *cid, *lowerName, *lowerValue;
   NSMutableString *resultPart;
   BOOL skipAttribute;
 
@@ -518,11 +518,12 @@ - (void) startElement: (NSString *) _localName
                        || [name isEqualToString: @"action"]
                        || [name isEqualToString: @"formaction"])
                 {
-                  value = [[_attributes valueAtIndex: count] lowercaseString];
-                  skipAttribute = ([value rangeOfString: @"://"].location == NSNotFound
-                                   && ![value hasPrefix: @"mailto:"]
-                                   && ![value hasPrefix: @"#"]) ||
-                    [value hasPrefix: @"javascript:"];
+                  value = [_attributes valueAtIndex: count];
+                  lowerValue = [value lowercaseString];
+                  skipAttribute = ([lowerValue rangeOfString: @"://"].location == NSNotFound
+                                   && ![lowerValue hasPrefix: @"mailto:"]
+                                   && ![lowerValue hasPrefix: @"#"]) ||
+                    [lowerValue hasPrefix: @"javascript:"];
                   if (!skipAttribute)
                     [resultPart appendString: @" rel=\"noopener\""];
                 }