Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Require current password on password change #285

Merged

Conversation

the-nic
Copy link
Contributor

@the-nic the-nic commented Jul 24, 2020

Increase security by requiring the current password when changing the
password. This increases the security for cases such as XSS, or just a
forgotten browser window left open.

Fixes #4140

@the-nic the-nic force-pushed the bugfix/4140-require-current-password-on-change branch from 9cc4a1c to bf1cc01 Compare July 24, 2020 10:45
@cgx
Copy link
Contributor

cgx commented Jul 24, 2020

Please add the string Current password to UI/PreferencesUI/English.lproj/Localizable.strings. Thanks!

Increase security by requiring the current password when changing the
password. This increases the security for cases such as XSS, or just a
forgotten browser window left open.

Fixes #4140
@the-nic the-nic force-pushed the bugfix/4140-require-current-password-on-change branch from bf1cc01 to d7e1140 Compare July 25, 2020 08:11
@the-nic
Copy link
Contributor Author

the-nic commented Jul 25, 2020

Sure! Done.

@cgx cgx merged commit 2300fe8 into Alinto:master Jul 27, 2020
@the-nic the-nic deleted the bugfix/4140-require-current-password-on-change branch July 27, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants