Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to typings as js_bindings is discontinued #48

Open
gaetschwartz opened this issue Jun 27, 2023 · 5 comments
Open

Migrate to typings as js_bindings is discontinued #48

gaetschwartz opened this issue Jun 27, 2023 · 5 comments

Comments

@gaetschwartz
Copy link
Contributor

js_bindings is extensively used throughout the repo, but it's discontinued in favour of typings.

Typings also has Deno bindings generated so a lot of code is not needed anymore.

@MutantPiggieGolem1
Copy link

I second this. My code no longer even compiles due to errors like the following:

Compiling 1 functions
Compilation of the Dart entry file failed:

../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/fetch.dart:377:55:
Warning: Initializers for parameters are ignored on static interop external functions.
  external static Response redirect(String url, [int? status = 302]);
                                                      ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/dom.dart:1835:36:
Warning: Initializers for parameters are ignored on static interop external functions.
  external factory Text._([String? data = '']);
                                   ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/dom.dart:1992:39:
Warning: Initializers for parameters are ignored on static interop external functions.
  external factory Comment._([String? data = '']);
                                      ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/css_typed_om_1.dart:1173:16:
Warning: Initializers for parameters are ignored on static interop external functions.
      [dynamic alpha = 1]);
               ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/css_typed_om_1.dart:1205:16:
Warning: Initializers for parameters are ignored on static interop external functions.
      [dynamic alpha = 1]);
               ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/css_typed_om_1.dart:1237:16:
Warning: Initializers for parameters are ignored on static interop external functions.
      [dynamic alpha = 1]);
               ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/css_typed_om_1.dart:1270:16:
Warning: Initializers for parameters are ignored on static interop external functions.
      [dynamic alpha = 1]);
               ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/css_typed_om_1.dart:1302:16:
Warning: Initializers for parameters are ignored on static interop external functions.
      [dynamic alpha = 1]);
               ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/css_typed_om_1.dart:1334:16:
Warning: Initializers for parameters are ignored on static interop external functions.
      [dynamic alpha = 1]);
               ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/css_typed_om_1.dart:1366:16:
Warning: Initializers for parameters are ignored on static interop external functions.
      [dynamic alpha = 1]);
               ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/css_typed_om_1.dart:1398:16:
Warning: Initializers for parameters are ignored on static interop external functions.
      [dynamic alpha = 1]);
               ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/encoding.dart:80:16:
Warning: Initializers for parameters are ignored on static interop external functions.
      [String? label = 'utf-8', TextDecoderOptions? options]);
               ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/encoding.dart:147:16:
Warning: Initializers for parameters are ignored on static interop external functions.
      [String? label = 'utf-8', TextDecoderOptions? options]);
               ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/webrtc.dart:2200:59:
Warning: Initializers for parameters are ignored on static interop external functions.
  external factory RTCError._(RTCErrorInit init, [String? message = '']);
                                                          ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/webidl.dart:26:16:
Warning: Initializers for parameters are ignored on static interop external functions.
      [String? message = '', String? name = 'Error']);
               ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/webidl.dart:26:38:
Warning: Initializers for parameters are ignored on static interop external functions.
      [String? message = '', String? name = 'Error']);
                                     ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/geometry_1.dart:43:35:
Warning: Initializers for parameters are ignored on static interop external functions.
      [/* double | NaN */ dynamic x = 0,
                                  ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/geometry_1.dart:44:34:
Warning: Initializers for parameters are ignored on static interop external functions.
      /* double | NaN */ dynamic y = 0,
                                 ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/geometry_1.dart:45:34:
Warning: Initializers for parameters are ignored on static interop external functions.
      /* double | NaN */ dynamic z = 0,
                                 ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/geometry_1.dart:46:34:
Warning: Initializers for parameters are ignored on static interop external functions.
      /* double | NaN */ dynamic w = 1]);
                                 ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/geometry_1.dart:93:35:
Warning: Initializers for parameters are ignored on static interop external functions.
      [/* double | NaN */ dynamic x = 0,
                                  ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/geometry_1.dart:94:34:
Warning: Initializers for parameters are ignored on static interop external functions.
      /* double | NaN */ dynamic y = 0,
                                 ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/geometry_1.dart:95:34:
Warning: Initializers for parameters are ignored on static interop external functions.
      /* double | NaN */ dynamic z = 0,
                                 ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/geometry_1.dart:96:34:
Warning: Initializers for parameters are ignored on static interop external functions.
      /* double | NaN */ dynamic w = 1]);
                                 ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/geometry_1.dart:175:35:
Warning: Initializers for parameters are ignored on static interop external functions.
      [/* double | NaN */ dynamic x = 0,
                                  ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/geometry_1.dart:176:34:
Warning: Initializers for parameters are ignored on static interop external functions.
      /* double | NaN */ dynamic y = 0,
                                 ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/geometry_1.dart:177:34:
Warning: Initializers for parameters are ignored on static interop external functions.
      /* double | NaN */ dynamic width = 0,
                                 ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/geometry_1.dart:178:34:
Warning: Initializers for parameters are ignored on static interop external functions.
      /* double | NaN */ dynamic height = 0]);
                                 ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/geometry_1.dart:224:35:
Warning: Initializers for parameters are ignored on static interop external functions.
      [/* double | NaN */ dynamic x = 0,
                                  ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/geometry_1.dart:225:34:
Warning: Initializers for parameters are ignored on static interop external functions.
      /* double | NaN */ dynamic y = 0,
                                 ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/geometry_1.dart:226:34:
Warning: Initializers for parameters are ignored on static interop external functions.
      /* double | NaN */ dynamic width = 0,
                                 ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/geometry_1.dart:227:34:
Warning: Initializers for parameters are ignored on static interop external functions.
      /* double | NaN */ dynamic height = 0]);
                                 ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/compute_pressure.dart:77:48:
Error: External extension members with the keyword 'static' on JS interop and @Native types are disallowed.
  external static Iterable<PressureSource> get supportedSources;
                                               ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/performance_timeline.dart:66:40:
Error: External extension members with the keyword 'static' on JS interop and @Native types are disallowed.
  external static Iterable<String> get supportedEntryTypes;
                                       ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/mediacapture_streams.dart:767:16:
Warning: Initializers for parameters are ignored on static interop external functions.
      [String? message = '']);
               ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/notifications.dart:50:46:
Error: External extension members with the keyword 'static' on JS interop and @Native types are disallowed.
  external static NotificationPermission get permission;
                                             ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/notifications.dart:52:27:
Error: External extension members with the keyword 'static' on JS interop and @Native types are disallowed.
  external static int get maxActions;
                          ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/websockets.dart:48:53:
Warning: Initializers for parameters are ignored on static interop external functions.
  external factory WebSocket._(String url, [dynamic protocols = const []]);
                                                    ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/push_api.dart:47:40:
Error: External extension members with the keyword 'static' on JS interop and @Native types are disallowed.
  external static Iterable<String> get supportedContentEncodings;
                                       ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/webusb.dart:210:13:
Warning: Initializers for parameters are ignored on static interop external functions.
      [int? bytesWritten = 0]);
            ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/webusb.dart:288:13:
Warning: Initializers for parameters are ignored on static interop external functions.
      [int? bytesWritten = 0]);
            ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/media_source_2.dart:101:28:
Error: External extension members with the keyword 'static' on JS interop and @Native types are disallowed.
  external static bool get canConstructInDedicatedWorker;
                           ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/indexeddb_3.dart:597:64:
Warning: Initializers for parameters are ignored on static interop external functions.
  external static IDBKeyRange lowerBound(dynamic lower, [bool? open = false]);
                                                               ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/indexeddb_3.dart:598:64:
Warning: Initializers for parameters are ignored on static interop external functions.
  external static IDBKeyRange upperBound(dynamic upper, [bool? open = false]);
                                                               ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/indexeddb_3.dart:600:14:
Warning: Initializers for parameters are ignored on static interop external functions.
      [bool? lowerOpen = false, bool? upperOpen = false]);
             ^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/js_bindings-0.1.2+2/lib/bindings/indexeddb_3.dart:600:39:
Warning: Initializers for parameters are ignored on static interop external functions.
      [bool? lowerOpen = false, bool? upperOpen = false]);
                                      ^
Error: Compilation failed.

@MutantPiggieGolem1
Copy link

#55 I PR'd a potential fix for this.

@agordeev
Copy link

agordeev commented Nov 9, 2023

Any updates? Basically, Dart Edge is useless as of now. It doesn't compile

@oliverbytes
Copy link

Updates please?

@Ehesp
Copy link
Member

Ehesp commented Feb 15, 2024

Might be able to get this working again now Dart 3.3 is live https://medium.com/dartlang/dart-3-3-325bf2bf6c13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants