Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: firebase_app_id_file.json does not exist for upload-symbols script #315

Closed
1 task done
OutdatedGuy opened this issue Jun 16, 2024 · 6 comments
Closed
1 task done
Labels
bug Something isn't working question Further information is requested

Comments

@OutdatedGuy
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues.

CLI Version

1.0.0

Firebase Tools version

13.11.2

Flutter Doctor Output

[✓] Flutter (Channel stable, 3.22.2, on macOS 14.5 23F79 darwin-arm64, locale en-IN)
    • Flutter version 3.22.2 on channel stable at /Users/user/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 761747bfc5 (11 days ago), 2024-06-05 22:15:13 +0200
    • Engine revision edd8546116
    • Dart version 3.4.3
    • DevTools version 2.34.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/user/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11609105)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15F31d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2024.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11609105)

[✓] VS Code (version 1.90.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.90.0

[✓] VS Code (version 1.91.0-insider)
    • VS Code at /Applications/Visual Studio Code - Insiders.app/Contents
    • Flutter extension version 3.90.0

[✓] Connected device (3 available)            
    • macOS (desktop)                 • macos                 • darwin-arm64   • macOS 14.5 23F79 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad • darwin         • macOS 14.5 23F79 darwin-arm64
    • Chrome (web)                    • chrome                • web-javascript • Google Chrome 126.0.6478.62

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Description

Running flutterfire configure does not create the firebase_app_id_file.json file anymore and instead creates firebase.json. Hence when running pod update or pod install below warning is printed:

Warning: firebase_app_id_file.json file does not exist. This may cause issues in upload-symbols. If this error is unexpected, try running flutterfire configure again.

Steps to reproduce

  1. Run flutterfire configure
  2. Run pod install
  3. See warning

Expected behavior

Either flutterfire configure should create a firebase_app_id_file.json file or the upload-symbols script shouldn't rely on firebase_app_id_file.json and maybe on firebase.json if necessary.

Screenshots

No response

Additional context and comments

No response

@OutdatedGuy OutdatedGuy added bug Something isn't working triage labels Jun 16, 2024
@patterueldev
Copy link

Encountering this as well. When I run pod install, I see the warning.
Screenshot 2024-06-19 at 2 36 09 PM

Prior to this, I never noticed this. And I was wondering why I keep receiving emails from Firebase about missing dSYM. Hopefully this gets fixed.

@Shatha-Naami
Copy link

flutterfire configure

I have the same warning and the same issue with uploading dSYM files to Crashlytics.
#314

@russellwheatley
Copy link
Member

Hey, could you let me know what you see on this path in your project?

.dart_tool/flutterfire/platforms/ios/default/flutterfire-cli-test-f6f57/app_id_file.json

For my project, I used default config and I used my Firebase project flutterfire-cli-test-f6f57 which is why I have the directories default/flutterfire-cli-test-f6f57/, yours will also match the setup you're using.

To give some context, when you run your app, it will add the relevant app_id_file.json file which is used to upload symbols here.

Screenshot 2024-06-25 at 10 03 18

Something must be incorrectly configured for it to be missing.

@russellwheatley russellwheatley added question Further information is requested and removed triage labels Jun 25, 2024
@OutdatedGuy
Copy link
Contributor Author

Hey, could you let me know what you see on this path in your project?

Hey @russellwheatley, I can see that this file exists with GOOGLE_APP_ID and FIREBASE_PROJECT_ID in it.


Additional Information:

What I think

Looks like there are two simultaneous issues:

  1. flutterfire_cli not adding the [firebase_crashlytics] Crashlytics Upload Symbols script
  2. firebase_crashlytics still relying on firebase_app_id_file.json instead of the new app_id_file.json file

@russellwheatley
Copy link
Member

russellwheatley commented Jun 25, 2024

@OutdatedGuy

One of my old project which didn't used the latest version (stable public release) of flutterfire_cli have the [firebase_crashlytics] Crashlytics Upload Symbols script as mentioned in the official docs, but the new project doesn't have it.

We don't use the script in the Firebase documentation for the latest FlutterFire CLI. We add a script to build phases that calls this method on FlutterFire CLI which uploads debug symbols: https://github.com/invertase/flutterfire_cli/blob/main/packages/flutterfire_cli/lib/src/commands/upload_symbols.dart

Also the firebase_crashlytics plugin still relies on the firebase_app_id_file.json file to upload dSYM.
firebase/flutterfire@70a3fbc/packages/firebase_crashlytics/firebase_crashlytics/ios/crashlytics_add_upload_symbols#L42-L55

We kept this method for backwards compatibility, if the old json file doesn't exist, it does nothing. So nothing to worry about.

@OutdatedGuy
Copy link
Contributor Author

We kept this method for backwards compatibility, if the old json file doesn't exist, it does nothing. So nothing to worry about.

So looks like the warning is from the backwards compatible firebase_crashlytics. Then I think this resolves the main point of this issue.

You can go ahead and close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants