Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve archiver gitignore matching #60

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

Ehesp
Copy link
Member

@Ehesp Ehesp commented Mar 6, 2024

Description

Fixes issues where the patterns extracted from .gitignore files were over matching, for example: **build** matches /some/path/my_build_file.dart

This update better handles gitignore specs, along with adding in verbose logging to indicate what's going on.

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

@Ehesp Ehesp self-assigned this Mar 6, 2024
@Ehesp Ehesp merged commit c36b29c into main Mar 7, 2024
7 checks passed
@Ehesp Ehesp deleted the fix/archiver-pattern-matching branch March 7, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants