-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package "@notifee/react-native" does not contain a valid config plugin. #799
Comments
Looks like the plugin directory has been deleted in version 7.8.0 Actually -- now that I look at the actual config plugin code that was removed -- I'm wondering if the idea is tha the config plugin isn't really needed anymore? I don't see anything called out in the changelog Might even suggest keeping a shim file, that prints a deprecation warning -- just to avoid the abruptness. Also these docs may need to be update |
@leggomuhgreggo I think you're right. I removed the notifee config plugin from my app.config.js and everything is working fine so far. Tried it with a development build and a production build |
@helenaford is this expected? If so, shall I create a PR to update the docs saying that for expo projects no further action is required after npm/yarn/pnpm installing |
@MaxAst that's correct. yes please! Although it might be that the docs are updated but the website isn't as we're trying to move over to another hosting platform |
I've also updated the release-notes to make it clear. thanks again, for flagging this |
Hello 👋, to help manage issues we automatically close stale issues. This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?
Thank you for your contributions. |
@helenaford I just cloned the repo to update the docs, but saw that the docs are indeed already updated w.r.t to not needing an expo config plugin. While I was on it, I also updated the docs w.r.t the eas build Android server image - The default Android server image on eas now uses JDK 11 by default: #824. Shall I leave this issue open until the new docs are deployed? |
I started a new project using expo v After adding notifee I started getting an error, Is it expected that after adding notifee / any prebuilt code, Expo Go is no longer a valid route for testing? EDIT: In case anyone else stumbles across this w/ the same issue, you have to run |
Hello 👋, to help manage issues we automatically close stale issues. This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?
Thank you for your contributions. |
Hi, is this been solved? |
same here :( |
If you are building on your own machine, just add in your
|
Sorry but in official documentation I still see: {
"name": "my app",
"plugins": [
"@notifee/react-native"
]
} is plugin needed for expo or not? |
Hello 👋, to help manage issues we automatically close stale issues. This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?
Thank you for your contributions. |
I think the docs still need to be updated. Expo now uses JDK 11 by default and the instruction to add the config plugin still exist here https://notifee.app/react-native/docs/installation#expo-support |
Hi there @ryonwhyte 👋 - Expo support here specifically is community supported vs react-native CLI, and in general in an open source repository any statement that starts with "I think ... still need to be..." should be mentally read as "I'll propose a PR to..." - it's how the open source world moves forward... For anyone else following along I recognize there are a few PRs here that have gotten stale and not been merged over the last few months but I will go back and harvest everything I can, we will merge any + all reasonable PRs 🙏 |
@mikehardy Agreed! I see these changes have already been proposed. c441b9a |
Ah then it is likely the problem is just the docs site is not currently being published even after we merge docs. I had forgotten that was also an issue in this repo 😞 - Tracked down the issue for that one and reopened it #559 |
The doc stills said that expo plugin is still supported: https://notifee.app/react-native/docs/installation Ok, based on the commit linked above, basically just delete the notifee plugin lines in app.config.js then you are all set. |
Yep! @pencilcheck apologies that the published docs are currently not in sync with the committed docs. This is a bug and it is obviously not a great developer experience. If you click in to here you will see current docs: https://github.com/invertase/notifee/blob/main/docs-react-native/react-native/docs/overview.md |
The docs still aren't right though because they say you need to use some old ubuntu image, when in reality the current default will suffice.
|
Ah, I think I may have just fixed building with JDK11+ ( #933 - such that JDK17 will work and JDK21 won't work yet but will work once google finally releases android gradle plugin 8.2.1 with a bugfix) If you can find post a PR to whatever docs page is still recommending that it will get done before I get a chance to |
Hi @mikehardy, apologies for tagging you out of the blue. Trying to use this library and I got confused about the docs. I looked into the repo for the commited docs, followed through and still got into an issue such as #350. What docs should be followed in order to give a complete walk-through for a correct setup for the library? |
Hmm should be the docs in git 🤔 |
Hello guys, for ios, where is docs currently? |
I've started getting this error today
when running
expo start -c
oreas build
. AFAIK, I haven't made any changes that could have led to this errorThe text was updated successfully, but these errors were encountered: