Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☂️ Bring Modular V9 to React Native Firebase #6705

Closed
17 tasks done
Lyokone opened this issue Nov 17, 2022 · 24 comments
Closed
17 tasks done

☂️ Bring Modular V9 to React Native Firebase #6705

Lyokone opened this issue Nov 17, 2022 · 24 comments
Assignees
Labels
Keep Open avoids the stale bot Type: In Progress

Comments

@Lyokone
Copy link
Contributor

Lyokone commented Nov 17, 2022

This issue will track the progress and gather feedback for bringing the V9 API of Firebase to React Native Firebase.

The objective is to have a compatible API so people may adopt the V9 API if they wish, or if they were already using firebase-js-sdk v9 and find they need some native features provided by react-native-firebase, they may adopt react-native-firebase with zero code changes.

Modules

@Lyokone Lyokone self-assigned this Nov 17, 2022
@mikehardy mikehardy added Keep Open avoids the stale bot Type: In Progress labels Nov 17, 2022
@github-actions

This comment was marked as resolved.

@github-actions github-actions bot added the Type: Stale Issue has become stale - automatically added by Stale bot label Dec 15, 2022
@Lyokone Lyokone removed the Type: Stale Issue has become stale - automatically added by Stale bot label Dec 15, 2022
@jeveloper

This comment was marked as resolved.

@mikehardy

This comment was marked as resolved.

@Salakar Salakar pinned this issue Jan 13, 2023
@adrianotadao
Copy link

hey @Lyokone @mikehardy, thank you for your hard work on it! #heroes

I'm quite interested in the firestore item, is this progress list up to date?

Thank you

@Lyokone
Copy link
Contributor Author

Lyokone commented Mar 1, 2023

Hello @adrianotadao, Firestore hasn't yet been brought to modular v9 APIs. It will probably be dealt with in the coming weeks.

@Nantris
Copy link

Nantris commented Mar 28, 2023

If I'm not mistaken, at least one of these items and possibly several are released and need to be checked off in this issue.

storage appears to be exposed but is unchecked: #6958

I guess auth and database are a ways off since they don't show any relevant PRs on the list? Or do those maybe need updating too? Those are the two that are preventing us from upgrading from using the web version to using react-native-firebase in our project.

@Lyokone

@mikehardy
Copy link
Collaborator

@slapbox only storage status was out of date, we just merged+released that one

If there is no relevant PR then the work is not in progress yet, we don't provide ETAs but they are all "next on the list" basically. Slowly but surely...

@github-actions
Copy link

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.

@github-actions github-actions bot added the Type: Stale Issue has become stale - automatically added by Stale bot label Apr 28, 2023
@Nantris
Copy link

Nantris commented Apr 28, 2023

Not stale.

@github-actions github-actions bot removed the Type: Stale Issue has become stale - automatically added by Stale bot label Apr 28, 2023
@jeveloper
Copy link

Github bot doesn't seem to care for work-life balance. Let's not be pushed into a rat race :)
Thanks for the great work.

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.

@github-actions github-actions bot added the Type: Stale Issue has become stale - automatically added by Stale bot label Jun 6, 2023
@Nantris
Copy link

Nantris commented Jun 6, 2023

Not stale. Thanks to the team and the community for the ongoing great work!

@github-actions github-actions bot removed the Type: Stale Issue has become stale - automatically added by Stale bot label Jun 6, 2023
@github-actions
Copy link

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.

@github-actions github-actions bot added the Type: Stale Issue has become stale - automatically added by Stale bot label Jul 11, 2023
@Nantris
Copy link

Nantris commented Jul 11, 2023

Not stale.

@github-actions github-actions bot removed the Type: Stale Issue has become stale - automatically added by Stale bot label Jul 11, 2023
@RobertSasak
Copy link

I am unable to see any exposed modular functions. Is it possible to try, for instance, modular storage functions in the latest 18.2.0 release? If yes, could you please provide an example?

@apetta
Copy link
Contributor

apetta commented Sep 9, 2023

Would be great to try this!

@Nantris
Copy link

Nantris commented Sep 19, 2023

Database work is done and can be checked off!

#7136

Thanks @exaby73 and others who worked on it!

@exaby73
Copy link
Contributor

exaby73 commented Sep 19, 2023

Just a couple more items to be checked off :)

@Nantris
Copy link

Nantris commented Sep 20, 2023

Are there any known changes in Firebase 10 which these changes might not be compatible with?

@exaby73
Copy link
Contributor

exaby73 commented Sep 21, 2023

We'd have to compare the release notes I guess, starting with the initial release of v10. We can worry about that once we catch up to V9 first :)

@exaby73
Copy link
Contributor

exaby73 commented Oct 18, 2023

All modules have been migrated to the modular APIs, with the merge of #7390. This has been a long running effort but we've finally gotten there 🎉

@exaby73 exaby73 closed this as completed Oct 18, 2023
@AbenezerBayeh
Copy link

AbenezerBayeh commented Jan 23, 2024

Having trouble converting Firebase JS v9 code to the modular React Native Firebase equivalent. Can you please assist by providing the import changes needed to do the following commands without any further code changes?

`
import {
doc,
updateDoc,
getDoc,
onSnapshot,
arrayUnion,
arrayRemove,
writeBatch,
increment
} from 'firebase/firestore';

const batch = writeBatch(db);
const userRef = doc(db, 'users', userID);

//batch
batch.update(userRef,{
[user.books]: arrayUnion(bookName),
[user.visits]: increment(1)
})

//updateDoc
await updateDoc(userRef, {
[user.books]: arrayRemove(bookName),
});

AND

//getDoc
const userSnap = await getDoc(userRef);
var documentData = userSnap.data();

//onSnapshot
const unsubscribe = onSnapshot(doc(db, 'users', userID), snap => {
const documentData = snap.data();

});

`

Thank you!

@RobertSasak
Copy link

Simply import from '@react-native-firebase/auth' as you woule normally do.

import {
  getAuth,
  onAuthStateChanged,
  signInAnonymously,
} from '@react-native-firebase/auth'

However currently there seems to be only few Typescript definition files. So not TS support yet.

I openned a discussion about using modular syntax at #7597

@younes0
Copy link

younes0 commented Feb 27, 2024

@RobertSasak we could open an issue about the missing TS definitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Keep Open avoids the stale bot Type: In Progress
Projects
None yet
Development

No branches or pull requests

10 participants