Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Netlify for documentation previews #47

Closed
tomkerkhove opened this issue Feb 27, 2020 · 7 comments
Closed

Configure Netlify for documentation previews #47

tomkerkhove opened this issue Feb 27, 2020 · 7 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@tomkerkhove
Copy link
Contributor

Configure Netlify for documentation previews so that you can check the rendered version of the PR before merging.

This is what it looks like:
image

You can preview the docs but also blocks PRs where packaging fails.

Configuration

You can easily configure this by:

  1. Installing the Netlify GitHub app (https://github.com/apps/netlify)
  2. Create a Netlify account
  3. Add site for this GitHub repo
@SamVanhoutte SamVanhoutte added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 27, 2020
@SamVanhoutte
Copy link
Contributor

Makes sense and does not look like a lot of work.
@grik001 - could you plan this ?

@grik001
Copy link
Collaborator

grik001 commented Feb 27, 2020

@SamVanhoutte Sure will look into it.

@tomkerkhove
Copy link
Contributor Author

Happy to help if you have questions!

@tomkerkhove
Copy link
Contributor Author

It's configured under my account and an example is open on #56.

@SamVanhoutte we should check if we can buy a plan if you want to because I cannot invite anybody in free tier apparently. OSS tier is not an option given it's commercial product.

@tomkerkhove
Copy link
Contributor Author

I think we can close this one

@SamVanhoutte
Copy link
Contributor

close as in : "it's been done", or "will not do it" ?

@tomkerkhove
Copy link
Contributor Author

Previews are done with sample in #56 but the plan is still pending but not blocking I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants