Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Write-State on Object-View #1317

Closed
darkiop opened this issue Feb 12, 2022 · 31 comments
Closed

Show Write-State on Object-View #1317

darkiop opened this issue Feb 12, 2022 · 31 comments

Comments

@darkiop
Copy link
Contributor

darkiop commented Feb 12, 2022

Display the write status of a data point ("write": true/false) in the object view. A small graphic (an open lock?) would suffice.

@Apollon77
Copy link
Collaborator

Why this is needed? In "non expertmode" all states that are read-only can not be set at all ... and in expert mode it is allowed ... so non expert mode should already have it indirectly. Please provide more details why this is needed?

@darkiop
Copy link
Contributor Author

darkiop commented Feb 23, 2022

Hi Ingo, sorry - missed the answer.
First and foremost, the idea was to be able to see directly (especially with new, still unknown objects) which are intended for the writing process. So more of a "getting to know". Currently I'm always clicking through the RAW of the DP.
I knew that as an "expert" I could write anything, but that rarely makes sense to do so ;)

@GermanBluefox
Copy link
Contributor

image
Implemented in Admin6

@Apollon77
Copy link
Collaborator

I'm not sure if this * is really "underatsndable" ... Dumb question: why not extending the "state value mouseover-thingy and add a writable: yes or such at the bottom, maybe after a line break or such?

@mickym2
Copy link

mickym2 commented Jun 4, 2022

Instead of using the value column to reflect the changeable status of the state, put a lock (open or locked) into the settings column. If change the read/write status you can directly change it there or you just ignore this or grey it out.

image

@Grizzelbee
Copy link

@Apollon77
I'm not sure if this * is really "underatsndable" ... Dumb question: why not extending the "state value mouseover-thingy and add a writable: yes or such at the bottom, maybe after a line break or such?

Either that - or since we already use some colors and should think about to add a color-legend somewhere:

  • Read/Writeable stays with red/green color depending on the ACK-State; just like now
  • ReadOnly simply gets blue color (since there is no changing ACK State)
  • yellow color -> seeing it on the screenshot above but never seen in my system so I don't know what it means.

I don't like the asterisk as well - on the first look it looked like dirt on my monitor and was pretty confusing.

@Apollon77
Copy link
Collaborator

I think colors are already used for quality, so they are "no option" in my eyes - we wopuld only have the background color :-)

@GermanBluefox
Copy link
Contributor

Changing of background colors looks terrifying

@GermanBluefox
Copy link
Contributor

Instead of using the value column to reflect the changeable status of the state, put a lock (open or locked) into the settings column. If change the read/write status you can directly change it there or you just ignore this or grey it out.

image

It will take too much place

@Apollon77
Copy link
Collaborator

Then maybe really makeing the tooltip with value "Longer "by adding a writeable" at the end or such

@Apollon77
Copy link
Collaborator

2022-06-09 13 04 34
Somewhere there a red "readonly" if not writebale ... or a green "writable" es would be not on the first view but still easy accessable

Alternatively we could add it only in the "pencil dialog" where you can set a value and show a red warning "please not this state is not writeable...."

@Diginix
Copy link

Diginix commented Jun 9, 2022

I would prefer the tooltip. There is enough space and it is a not that much important information that it needs an icon or color in the object table.

@Grizzelbee
Copy link

Changing of background colors looks terrifying

I expected that. ;)

I would prefer the tooltip.

I don't really like the idea - because you don't get the information "on first sight" - where it would be needed. It will be really annoying to hover over each and every state and wait for the tooltip to get the information. When you examine a new adapter this would take ages.

What about a second - vertical standing - pencil in green und red? This would take only a few pixels.

@mickym2
Copy link

mickym2 commented Jun 9, 2022

I would prefer then - and do not see the problem why the button to write is not just diabled:
image

I get a warning in the log - but why is it possible at all to write a value?

@GermanBluefox
Copy link
Contributor

I get a warning in the log - but why is it possible at all to write a value?

I want it. For tests purposes

@GermanBluefox
Copy link
Contributor

I would prefer then - and do not see the problem why the button to write is not just diabled: image

I get a warning in the log - but why is it possible at all to write a value?

This is good idea:
image

But of course it should be somehow shown in main table

@GermanBluefox
Copy link
Contributor

What about a second - vertical standing - pencil in green und red? This would take only a few pixels.

There is no place for any pencils. Read the issues and you will understand that people trying to work with admin on mobile devices and claiming, that they do not see all information

@Apollon77
Copy link
Collaborator

maybe really a different color of the "set value" button together with a red note when it is readonly

@Grizzelbee
Copy link

But ... wasn't the initial idea/request to get a better overview in the device tree which states are writeable or readonly? At least that's what is currently implemented.
Maybe I don't understand it at all - so it may be better to remain silent.

@Apollon77
Copy link
Collaborator

Yes you are right ... but the options are not that easy, or? So we just discuss alternatives that also "at least allow to see it when needed". In fact it is only an issue also in "expertmode" or?

@Grizzelbee
Copy link

I'm sorry - but not from my perspective.
I would love to be able in std. mode to see directly in the device tree whether a state is intended to be switched (writeable) or delivers a plain information (readonly). Just like it is right now. Thats pretty perfect - my only point was, that the asterisk isn't the perfect solution - since it looked like dirt on my screen at first sight.
Currently I'm (from a simple user perspective) able to see at one sight whether a state is intended to be editable or not in all views.

That's awsome! A great benefit when testing/getting familiar with new adapters or connecting states to a gui.

grafik

Maybe the paper sheet in front of the states delivers an option:

  • Red outlined with an R inside for ReadOnly
  • Green outlined with an W inside for Writeables
    The color/letter combination even won't leave the color blinds behind.

@Diginix
Copy link

Diginix commented Jun 9, 2022

+1 because it uses no additional space. And the Papericon itself contains no information yet.

@mickym2
Copy link

mickym2 commented Jun 9, 2022

I'm sorry - but not from my perspective. I would love to be able in std. mode to see directly in the device tree whether a state is intended to be switched (writeable) or delivers a plain information (readonly). Just like it is right now. Thats pretty perfect - my only point was, that the asterisk isn't the perfect solution - since it looked like dirt on my screen at first sight. Currently I'm (from a simple user perspective) able to see at one sight whether a state is intended to be editable or not in all views.

That's awsome! A great benefit when testing/getting familiar with new adapters or connecting states to a gui.

grafik

Maybe the paper sheet in front of the states delivers an option:

  • Red outlined with an R inside for ReadOnly
  • Green outlined with an W inside for Writeables
    The color/letter combination even won't leave the color blinds behind.

In my opinion it must not be outlined but an Icon with an "r" or lock in it and a blank icon would be sufficient as well. So no additional space is needed but is noticeable at once.

@GermanBluefox
Copy link
Contributor

Like this?
image

@mickym2
Copy link

mickym2 commented Jun 9, 2022

Like this? image

Exactly :)

@Grizzelbee
Copy link

Grizzelbee commented Jun 9, 2022

Not perfect - but okay. It's the most minimalistic way. And the lock looks a bit bold to me.
I don't really like the absence of an information to be interpreted as an information (lock/no lock).
Therefore I still prefer something in the sense of my proposal.

  • r/w for readOnly/writeable;
  • i/s for information/switch (even when switch doesn't perfectly fit here to the role="switch"; but in the end something gets changed)
  • i/c for information/changeable
  • open lock/closed lock
  • Green/red Pencil inside the paper sheet
  • many other options ...

color is optional - I agree; but fancy. ;-) And may eventually help with the bold lock.

Edit:
A pencil is very intuitive to me. In that case I change my mind and like: Empty paper/Paper with pencil. In that case there is no lack of information due to the missing pencil.

@mickym2
Copy link

mickym2 commented Jun 9, 2022

Another option could be the state icon with the lock under type - to put a lock inside (but this disappears if you switch to the time view) - but matches probably more the meaning to visualize a "read-only" state. The advantage to have in the type or role column would be that you can filter to read-only states as well.

@Apollon77
Copy link
Collaborator

Adjusting the icon is a great idea ... maybe turn it around? icon with a pencil icon for "editable"? and nothing for not?

@Grizzelbee
Copy link

Adjusting the icon is a great idea ...

thanks. :)

maybe turn it around? icon with a pencil icon for "editable"? and nothing for not?

Thats no turn around but exactly what I meant - since a pencil is pretty intuitive to what we like to say.
So it doesn't need much explanation (hopefully! but a tooltip never does harm). ;-)

@GermanBluefox
Copy link
Contributor

GermanBluefox commented Jun 9, 2022

I implemented it already (twice). if someone does not like it. PR is welcome. Here: https://github.com/ioBroker/ioBroker.admin/blob/master/src-rx/src/components/ObjectBrowser.jsx#L3961

@Grizzelbee
Copy link

Grizzelbee commented Jun 10, 2022

@GermanBluefox
No need to react that grumpy.
The only further change @Apollon77 and me suggested/considered/discussued in the ongoing discussion was to change the additional icon to a pencil instead of a lock since it seems to be more intuitive to us in that context.
If discussions and ideas aren't welcome I'll stop it. I'll find another way to waste my time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants