Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing and/or wrong described Astrofunctions #591

Closed
Pittini opened this issue Jun 1, 2020 · 2 comments
Closed

Missing and/or wrong described Astrofunctions #591

Pittini opened this issue Jun 1, 2020 · 2 comments
Labels

Comments

@Pittini
Copy link

Pittini commented Jun 1, 2020

In the documentary, those Astro functions are described (see end of this text):

So, there is a:
"goldenHourEnd": morning golden hour (soft light, best time for photography) ends

and a

"goldenHour": evening golden hour starts

  1. A morning goldenHourEnd doesnt exists, what it means is the "blueHourEnd" -https://en.wikipedia.org/wiki/Blue_hour - and should be renamed.
  2. The time seems correct, but its decribed as End. When its starts? Thats missing.
  3. The real goldenhour is set correct, but here is missing when it ends. What is described as goldenHourEnd is completely wrong, see .1.

"sunrise": sunrise (top edge of the sun appears on the horizon)
"sunriseEnd": sunrise ends (bottom edge of the sun touches the horizon)
"goldenHourEnd": morning golden hour (soft light, best time for photography) ends
"solarNoon": solar noon (sun is in the highest position)
"goldenHour": evening golden hour starts
"sunsetStart": sunset starts (bottom edge of the sun touches the horizon)
"sunset": sunset (sun disappears below the horizon, evening civil twilight starts)
"dusk": dusk (evening nautical twilight starts)
"nauticalDusk": nautical dusk (evening astronomical twilight starts)
"night": night starts (dark enough for astronomical observations)
"nightEnd": night ends (morning astronomical twilight starts)
"nauticalDawn": nautical dawn (morning nautical twilight starts)
"dawn": dawn (morning nautical twilight ends, morning civil twilight starts)
"nadir": nadir (darkest moment of the night, sun is in the lowest position)

@Pittini Pittini changed the title Missing and wrong described Astrofunctions Missing and/or wrong described Astrofunctions Jun 1, 2020
@stale
Copy link

stale bot commented Aug 30, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days. Please check if the issue is still relevant in the most current version of the adapter and tell us. Also check that all relevant details, logs and reproduction steps are included and update them if needed. Thank you for your contributions.
Dieses Problem wurde automatisch als veraltet markiert, da es in letzter Zeit keine Aktivitäten gab. Es wird geschlossen, wenn nicht innerhalb der nächsten 7 Tage weitere Aktivitäten stattfinden. Bitte überprüft, ob das Problem auch in der aktuellsten Version des Adapters noch relevant ist, und teilt uns dies mit. Überprüft auch, ob alle relevanten Details, Logs und Reproduktionsschritte enthalten sind bzw. aktualisiert diese. Vielen Dank für Eure Unterstützung.

@stale stale bot added the wontfix label Aug 30, 2020
@stale
Copy link

stale bot commented Sep 6, 2020

This issue has been automatically closed because of inactivity. Please open a new issue if still relevant and make sure to include all relevant details, logs and reproduction steps. Thank you for your contributions.
Dieses Problem wurde aufgrund von Inaktivität automatisch geschlossen. Bitte öffnet ein neues Issue, falls dies noch relevant ist und stellt sicher das alle relevanten Details, Logs und Reproduktionsschritte enthalten sind. Vielen Dank für Eure Unterstützung.

@stale stale bot closed this as completed Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant