Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to add custom start parameters to instances #844

Closed
Anzic23 opened this issue Apr 29, 2020 · 17 comments · Fixed by #2123
Closed

Allow to add custom start parameters to instances #844

Anzic23 opened this issue Apr 29, 2020 · 17 comments · Fixed by #2123

Comments

@Anzic23
Copy link

Anzic23 commented Apr 29, 2020

same error - https://stackoverflow.com/questions/59898050/axios-ssl-error-with-node-12-ssl-routinesssl-choose-client-versionunsupporte
this script stopped working.
samsung-air.txt

Node.js v12.16.2
NPM 6.14.4
js-controller 3.0.20

2020-04-30 00:31:27.293 - error: javascript.0 (14338) uncaught exception: 140145197954880:error:1425F102:SSL routines:ssl_choose_client_version:unsupported protocol:../deps/openssl/openssl/ssl/statem/statem_lib.c:1942:
--
2020-04-30 00:31:27.293 - error: javascript.0 (14338) Error: 140145197954880:error:1425F102:SSL routines:ssl_choose_client_version:unsupported protocol:../deps/openssl/openssl/ssl/statem/statem_lib.c:1942:



@Apollon77
Copy link
Collaborator

Yes, we will add error handlers for all adapters that use it, but in fact ... what is wrong with the certifictaes?

@Apollon77
Copy link
Collaborator

Can you try to generate new certificates in iobroker? Use "iobroker cert" commands for that!

@Apollon77
Copy link
Collaborator

ANd: The full error/stack trace would be interesting. I would say you need to make sure to handle all errors in your script correctly. I do not nsee any topic for js-controller here ...

@Apollon77
Copy link
Collaborator

PS: or is this issues meaned to be a "feature request" to add "--tls-min-v1.0" as parameters when we execute certain adapter processes to allow insecure communication methods?

@Apollon77 Apollon77 reopened this Apr 30, 2020
@Anzic23
Copy link
Author

Anzic23 commented Apr 30, 2020

I'm not sure I know how to correctly install the certificate from the module instructions https://github.com/cicciovo/homebridge-samsung-airconditioner/blob/master/README.md

@Anzic23
Copy link
Author

Anzic23 commented Apr 30, 2020

ANd: The full error/stack trace would be interesting. I would say you need to make sure to handle all errors in your script correctly. I do not nsee any topic for js-controller here ...

perhaps. But on previous versions it worked without problems. error appeared after update nodejs and js-controller

@Anzic23
Copy link
Author

Anzic23 commented Apr 30, 2020

PS: or is this issues meaned to be a "feature request" to add "--tls-min-v1.0" as parameters when we execute certain adapter processes to allow insecure communication methods?

Yes, I think

@Apollon77 Apollon77 changed the title SSL error with Node 12 Allow to add custom start parameters to instances May 5, 2020
@Apollon77 Apollon77 added this to Planned in Version 3.2.x (Grace) via automation May 5, 2020
@Apollon77 Apollon77 moved this from Planned to Backlog in Version 3.2.x (Grace) Dec 28, 2020
@Apollon77 Apollon77 added this to Planned in Next version 3.3.x (Hannah) via automation Jan 23, 2021
@Apollon77 Apollon77 removed this from Backlog in Version 3.2.x (Grace) Jan 23, 2021
@Apollon77 Apollon77 removed this from Planned in Next version 3.3.x (Hannah) May 1, 2021
@Anzic23
Copy link
Author

Anzic23 commented Jun 15, 2021

any news?

@Apollon77
Copy link
Collaborator

any news?

Not implemented till now ... PRs welcome

@foxriver76 foxriver76 moved this from Planned to Backlog in Next version 4.0.x (I...) Oct 12, 2021
@foxriver76
Copy link
Collaborator

Not really sure what is the goal here? new io-pack flag to allow starting adapters with --tls-min-v1.0?

@Apollon77
Copy link
Collaborator

No idea would be to make it generic and allow to specify "nodejs params to add", so in ioPackage have a common.nodejsProcessParams = '--tls-min-v1.0 --whateverparameelse'

So the adapte rdev can specify params that are used when starting the adapter

@foxriver76
Copy link
Collaborator

Yes, thus compact groups where one adapter would use a flag would alle be started with this flag of course. Will this may be a problem?

@Apollon77
Copy link
Collaborator

or the definition is that an adapter with thsi flag can never run as compact mode ... exactly because of this. I would not risk side effects here

@Apollon77 Apollon77 removed this from Backlog in Next version 4.0.x (I...) Dec 4, 2021
@Apollon77 Apollon77 added this to To do in Next version 4.1 (...) via automation Dec 4, 2021
@Apollon77 Apollon77 moved this from To do to Backlog in Next version 4.1 (...) Dec 4, 2021
@Apollon77
Copy link
Collaborator

We have another usecase now ... ioBroker/ioBroker.javascript#1022 would require to set --unhandled-rejections=warn as parameter to not restart on unhandled promises.

I propose something like

common.processCliParameters = ["first", "second", ...]

@Apollon77 Apollon77 moved this from Backlog to Planned in Next version 4.1 (...) Jun 9, 2022
@foxriver76
Copy link
Collaborator

foxriver76 commented Jun 9, 2022

Ok, then we say controller will start the instance as own process even if added to a compact group? We can also get some awareness via the schema to avoid usage of compact + the new flag. However, controller still needs to handle rule breaks.

@Apollon77
Copy link
Collaborator

meeehh ... you are right ... Elevating the parameterrs for the comapct group process i smaybe no good idea ... interesting ... yes needs to be considered

@Apollon77
Copy link
Collaborator

Another usecase ioBroker/ioBroker.parser#68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants