Not found .json (settings) at first run

[MicheleAnnunziata]

The first time incrementalbackup is run there is an exception caused by not reading the json file (which does not exist) in the destination folder. I made the example with Tar. I found the error in the getSetting method of the Tar class

It always ($settings_file) true and at the first time _destination->read goes in exception because the .json file will not be found

<?php
/**
     * Get the backup settings, # of backups and backup unix timestamps.
     *
     * @return mixed|object
     */
    public function getSettings()
    {
        //$settings_file = $this->_destination->getPath() . DIRECTORY_SEPARATOR . $this->getSettingsFile();
 $settings_file = $this->_destination->read(DIRECTORY_SEPARATOR . $this->getSettingsFile());
        if ($settings_file) {
            return json_decode($settings_file);
        } // first time to backup.
        else {
            return (object)array(
                "number" => 0,
                "backups" => array()
            );
        }
    }

[MicheleAnnunziata]

If i can suggest, i made the following change. Thank's for you job

/**
     * Get the backup settings, # of backups and backup unix timestamps.
     *
     * @return mixed|object
     */
    public function getSettings()
    {
        $settings_file = $this->_destination->getPath() . DIRECTORY_SEPARATOR . $this->getSettingsFile();
        //$settings_file = $this->_destination->read(DIRECTORY_SEPARATOR . $this->getSettingsFile());
        if (is_file($settings_file)) {
            $settings_file = $this->_destination->read(DIRECTORY_SEPARATOR . $this->getSettingsFile());
            return json_decode($settings_file);
        } // first time to backup.
        else {
            return (object)array(
                "number" => 0,
                "backups" => array()
            );
        }
    }

[iobotis]

Hi,

There is a solution about this. Since I am trying to support both local and ftp destinations for the backup-ed files, I cannot use "is_file".

I will test the solution and see if this solves the problem.