-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question: Issues that aren’t really major issues but are still issues #723
Comments
As I don't feel up to working on the tool (too tired or something along those liens though I hope to a bit later on today[0]) I do have some OT things to bring up which I'll do in additional comments. [0] I do have a zoom meeting today and I'll be done working on the repo for the day prior to this, whatever I got done, whether anything beyond the two open pull requests or not. |
Tolkien booksI know I told you about the book that Christopher blessed before his tragic death that you got and started to read (I still haven't had a chance to ... :( ) but I have also brought up some others that I wonder if you've got, books that are delightful.
There are others I know about that are great but that's a nice list if you didn't know about them. I have a book with pull outs of the maps but I can't access it .. they or it (might be one for Hobbit too - don't recall) are behind other books as I have limited space :( (not the only kinds of books that are inaccessible). Enjoy! |
Here's a fun one I just wrote ... /* programmer's party simulator */
#include <stdio.h>
#include <unistd.h>
void drink() { drink(); }
void party()
{
/*
* get pissed as a fart and do something
* exciting, I'm sure... (where exciting
* means stupid)
*/
drink();
}
/* programmer's social function */
void code() { printf("Go away! I'm programming!\n"); sleep(1); code(); }
int main()
{
/* skip the party: just go home and write code! */
goto home;
party();
home: code();
} Not that coding is the same as programming as such ... |
So... I discovered an interesting problem with Check this: make test
...
If you are curious, you may examine the newly created compressed tarball
by running the following command:
/opt/local/libexec/gnubin/tar -Jtvf test_ioccc/test_work/entry.test-1.1689530054.txz
As you entered an IOCCC contest ID of 'test', the compressed tarball
that was just formed CANNOT be used as an IOCCC entry. Please
do NOT email the Judges your entry!
yes: standard output: Broken pipe It only happens when running The question is do you want me to open an issue with this problem? Of course low priority right now probably but it's kind of annoying and I feel like it shouldn't be there. I'd guess you agree. UPDATE 0One way to fix it would be to add a |
.. and I see another problem with it - display - but probably insignificant given where it is:
Notice where the URL is. I guess that that's just the way the script is and it's not a problem - since it ends up having to not prompt (exactly why we need the |
Yes, we agree.
Yes, please. |
It might as I think solve the problem in the script in which case there might not be a need for an issue being opened. I opened this directly so that I'll see the email - tomorrow. Too tired to do it today I'm afraid and I'm hoping to be leaving (laptop) for the day soon. ... of course it brings up a question of is there a problem with the script that should be isolated? It might or might not have a problem. Not sure. Is it worth trying to determine the cause? I think probably not unless the |
I am thinking it might be a good idea to make an issue out of this and make it so that it's assigned to me. I am sure this will solve the problem but the other things are higher priority, right? If so do you think I should open an issue so I remember to do it later ? |
Go ahead and open an new issue for this. That was it can be noted while other matters are prioritized. |
I will do that tomorrow. I am about to have brownies that were pulled out of the oven about ten minutes ago. I just needed to take it easy today. I hope that tomorrow is a more productive day. Have a great night! |
Fixed it instead. See commit c776f09. Going to try and rest now though my body is telling me that won't last for long .. but possibly won't work on the other issues for a bit if not a while later. I do hope to work on it a bit today though but we'll see if I'm up to it. Hope you're sleeping well! |
Glad you got a laugh .. I knew you would. Whilst I'm still waking up and downloading (almost downloaded) the macOS update - 13.5? - here's the article for you: What I find hilarious is that it assumes that aliens have the same technology and use electricity and have same OSes and everything ... which is ridiculous and nonsense. Assuming there are aliens anyway: the real aliens are sadly ourselves. I don't believe in anything else: not until they're proven. And I hope they're not as humans destroy the unknown. Hope you're sleeping well! Two days in a row I slept in till almost 3 .. not enough for it to be good news but still somewhat encouraging. |
We were called away on a calc mission to help folks using FPGAs and DSPs to use a special "FNV-style" hash for the unusual 44-bit size of that hardware. Being probably one of the few people on the planet who fully understands the number theory behind FNV, they need our support. So was had to create: And make a special release of: We hope to return to creating manifest lists for IOCCC and to updating this repo .. after we undergo and recover from a 3-hour dental procedure tomorrow. |
No problem ... best wishes. |
Here's a funny and sad story. Someone apparently was bragging - on Facebook of course! - about their brilliance because they have an IQ of 84. She thought it is out of 100. Of course IQ testing is problematic and misses some critical things but this is still perfect. |
ChatGPT joke (copy pasted) about Bill Gates. It's a variation of an old one that I am sure you have seen before. -- When Bill Gates arrived at the pearly gates, St. Peter said, "Bill, you've done so much for humanity with Microsoft. I'll give you a choice: you can either go to heaven or take a quick tour of hell first. Then, you can make your decision." Bill thought for a moment and said, "Let me see hell first." As he descended into hell, he saw all the suffering and torment. The devil even offered him the latest versions of Windows with constant crashes and bugs. After a quick glimpse, Bill said, "Okay, I've seen enough. Let's go to heaven." When Bill reached heaven, he was greeted by angels and a beautiful, serene environment. St. Peter said, "So, what's your decision, Bill?" Bill smiled and replied, "As much as I appreciate what I've done with Microsoft, heaven seems like the more stable option!" -- I will be getting ready for sleep in about an hour from now but I do hope that I will be able to do more on the readme tomorrow morning. Best wishes for tomorrow! |
I made an enhancement to The idea is that since one might not know the right country name (exact) to find the country code it allows for substrings. Then since it would normally find the first and then print that one and not another it allows for Now when using Instead at the end if nothing is found it exits 1 but without an error. I think this is a useful enhancement to the tool but I want your views on it before I proceed. I'm going to do other things now. I'll do more tomorrow. |
I've made some slight improvements of this ... will look at doing a commit later. Maybe. I've been awake since far too early and I have a feeling today is going to be a long and difficult day. I hope to address the comments in the other issue but I'm not sure how much I'll manage. I'm going to try and rest again but I do have a bad feeling about today. So in case I am not very responsive today this is why and I'm sorry in advance! Hope you're sleeping well though. |
With commit 6f5cdb3 the location tool has been improved a fair bit! At first it modified the lookup functions but I decided for the cleaner approach of making re-entrant versions. The tool is now more useful for general use. The CHANGES.md and the git log and man page (with some examples added) should give you enough information on the new features and how it all works but otherwise there's always RTFS :-) :-) I do think this should be added to the general how to submit an entry faq but that can come later .. or maybe sometime soon. I think it would be wise if I added to a And I see you saw my reply earlier: sorry you were awake at the time. I'll be going afk soon I think but after that I'm not sure if I'll end up doing anything else here. Oh I think I can try and reply to the comment about json levels but it might not be anything beyond that. Anyway the location tool is now more useful and I think you'll be happy with how it was implemented. |
Just a fun link for you. I unfortunately am not feeling very well today so I am not sure when I will get to the other thread but I hope to do that later today. Anyway. Lava and Smoke Blanket Fagradalsfjall: https://earthobservatory.nasa.gov/images/151653/lava-and-smoke-blanket-fagradalsfjall |
See commit 06ce951 for an update relating to a cleanup of .gitignore files. In particular: Added Entries that belong to We removed many of the "generic exclusion lines" from the top level We did leave behind 5 "generic exclusion lines" in the above
It can be argued that even these files do not belong in a GitHub We made all of the non-generic exclusion lines "/-path" based. A number old entries in the |
It is a good idea to sometimes check the result of: make clobber
git status --ignored as well as: make release
git status --ignored |
With commit 59eebbc dbg version 3.0 2023-08-05 is ready for final review and testing.
With commit 32b2a74 dyn_test version 1.10 2023-08-05 ready for final review and testing.
With commit f602c74 updates per new parse_verbosity() interface from dbg.a were made. As changing the "dbg" interface is something that should not be done lightly, we plan to hold off on pushing both "dbg version 3.0 2023-08-05" and "dyn_test version 1.10 2023-08-05" until after a complete review of the changes have been made. The same goes for the "dyn_alloc" interface. If you, @xexyl, find any nits with the above commits, please change We plan to reject the existing pull requests in those repos in favor of the above commits as well as any additional correction commits that may be needed under the |
The We are now down to just these types of errors:
But these errors are just test suite errors. The "expected errors" errors no longer matches the true set of errors. UPDATE 0We have see this sort of Isn't there some way one can update test result comparison files such as Also the file UPDATE 1Because we do not (yet) understand what diff --git a/test_ioccc/txzchk_test.sh b/test_ioccc/txzchk_test.sh
index fed2f76c..dc5702e6 100755
--- a/test_ioccc/txzchk_test.sh
+++ b/test_ioccc/txzchk_test.sh
@@ -32,7 +32,6 @@
# tool. :-)
#
-
# setup
# attempt to fetch system specific path to the tools we need
@@ -487,13 +486,18 @@ run_test()
if ! cmp -s "$txzchk_err_file" "$TMP_STDERR_FILE"; then
echo "$0: Warning: in run_test: FAIL: $TXZCHK -w -v 0 -t $TAR -F $FNAMCHK -T -E txt $txzchk_test_file" | tee -a -- "$LOGFILE" 1>&2
echo "$0: Warning: in run_test: expected errors: $txzchk_err_file do not match result of test: $TMP_STDERR_FILE" 1>&2
+ if [[ $V_FLAG -ge 1 ]]; then
+ echo "$0: Warning: diff -u $txzchk_err_file $TMP_STDERR_FILE starts below" 1>&2
+ diff -u "$txzchk_err_file" "$TMP_STDERR_FILE" 1>&2
+ echo "$0: Warning: diff -u $txzchk_err_file $TMP_STDERR_FILE ends above" 1>&2
+ fi
if [[ $V_FLAG -lt 3 ]]; then
echo "$0: Warning: for more details try: $TXZCHK -w -v 3 -t $TAR -F $FNAMCHK -T -E txt -- $txzchk_test_file" | tee -a -- "$LOGFILE" 1>&2
else
echo "$0: Warning: for more details try: $TXZCHK -w -v $V_FLAG -t $TAR -F $FNAMCHK -T -E txt -- $txzchk_test_file" | tee -a -- "$LOGFILE" 1>&2
fi
echo | tee -a -- "${LOGFILE}" 1>&2
- EXIT_CODE=1
+ # EXIT_CODE=1 # XXX - disable this error until there is a better way to address errors thrown by this code - XXX #
fi
# Otherwise if there was output written to stderr it indicates that one or
# more unexpected errors have occurred. This won't be because of a new test The diff shows stuff that doesn't seem correct this part of the test suite. UPDATE 2With commit b8dfb9e we remove location_name from .auth.entry HOWEVER ... ... as noted above we disabled errors from For now UPDATE 3With commit d79295c the UPDATE 4OK, this fixed the for i in ./test_ioccc/test_txzchk/bad/*.txt; do ./txzchk -q -v 0 -w -T -E txt -F ./test_ioccc/fnamchk "$i" 2>"$i.err" ; done With commit 4e299b2 the |
Oh it's simple. I gave you a command but I can put it as a Makefile rule to automate it. Would that work? But if so would you mind restoring the script to what it was before? UPDATE 0In any case if that works I'll do it tomorrow morning. Bedtime soon. Going to read for a short bit and then sleep. |
With commit e2dbd50 we added a hard to type rule that can force expectations. Please review this change and edit it if needed. We will now go back to the other repo and now complete the results of recent |
Is the script restored to its previous state? As for the rule: the only thing that has to be done after it, of course, is to git add them and then commit them. If the Makefile should do this then I'm not sure in what way: certainly it can't do the commit as that involves things that require manual work. But perhaps it could have a message (an echo) after it's done saying what to do? What would you like me to do? Just let me know. And please let me know if the script was restored. I could maybe check to try and verify it but I want to make sure I don't miss anything. Thanks. Going to bed now. |
Yes.
It should just echo a message reminding some to update commit the update. |
We tried to UDPATE 0We will let you update your jparse repo if you want. |
Be sure to |
I did it differently. The script has an option that allows to update the files but only after asking the user if they are positive. It also requires the answer YES in all caps. After that it will tell them what to do next. The very next step of course is to run the script normally. There's an argument against having the script do it but this way it's all controlled by the script and of course the files exist for the script. It also allows for making the user pause to think about it to make sure they want to do it which the previous way did not do. Previously I didn't have the script do it because it does need manual inspection but this now takes care of it and at the same time doesn't make it hard. A simple command and answering YES does it now. At least for the rebuilding the files part. |
I thought we didn't want it populated until the three tools that we have postponed (to work on the other repo) are completed and tested. But maybe I misunderstand what you're saying? Please clarify. Thanks. |
Thanks for the reminder. Done already. |
As far as what that feature of the test script did: it was to make sure that the errors reported are actually correct. A sanity check you might say. Because there can be many different errors reported but are the CORRECT errors detected? That is the purpose of the err files. |
I believe that I have replied to everything but I am unsure what I need to do with the author handle terminology. Am I correct in saying that I just have to update the comments and the description in the string (sent to the users)? If there's more that you need me to do please let me know. I will then probably be able to do that tomorrow. Thanks. Off to do other things. Have a great day! |
You are correct .. we forgot that point. |
Thanks for confirming. Well I have other things to do now. I'll reply to other things either later today or else tomorrow morning. |
Okay I was going to update the comments and strings for the author_handle but I noticed something that complicate matters. The idea originally was it would allow only lower case characters. Okay but I see in the function /* IOCCC author handle must use only lower case POSIX portable filename and + chars */
test = posix_plus_safe(str, false, false, true); Now what are those booleans? * given:
* str - string to test
* lower_only - true ==> only lower case characters are allowed
* - false ==> both UPPER and lower case characters are allowed
* slash_ok - true ==> / is allowed as str can be a path
* false ==> / is NOT allowed, str is a basename only
* first - true ==> str is at beginning, perform first char check
* false ==> str may be in the middle, skip first char check
* .. so it seems like we can impose a lower case limit if we want. However now I think on it .. was the problem that the other repo does not have that limitation? Should I then change the comments and strings to have the regexp (to make it easy): ^[0-9A-Za-z][0-9A-Za-z._+-]*$* I'm not sure what to do and given how tired I am right now I don't trust my judgement either. What do you need it to say? Thanks. Will probably not finish it until tomorrow but we'll see. |
If by that you mean changing something on that other repo to match the above regexp, and perform whatever changes in that other repo that might be needed as a result, then sure. In this repo, the comments for * If slash_ok is false:
...
* If first is true:
...
* If lower_only is false, then the string must match:
*
* ^[0-9A-Za-z][0-9A-Za-z._+-]*$ which is what we want for |
I thought we only wanted lower case? |
Will reply to the rest another time if there's more to reply to. |
Oh. I see. For this repo. Okay. Then I guess I should update the comments and strings in the other repo? |
If you look in thr other repo at files such as author/Cody_Boone_Ferguson.json we have definitely gone for mixed case. |
Yes. |
True .. I remember. |
Running |
All good .. pull request incoming. I also noticed a typo in the regexp above .. not sure if that was your doing or mine but it had a |
See commit dd9c10c for the fixes. |
With commit 69b0fc9 and e613245 we have finished some needed cleanup of the mkiocccentry repo. NOTE: the INFO_VERSION, AUTH_VERSION, and MIN_TIMESTAMP changed due to the removal of the formed_UTC JSON member from TODO: Test Release 1.0.64 2024-05-18. Modify/fix as/if needed. Then once all is well, git tag the repo as version 1.1 and call it a new latest release. UPDATE 0When UPDATE 1We plan to re-release the current code base as version 1.1, replacing the very old version 1.0 as the latest release, @xexyl, unless we find something today that needs fixing. |
Thanks for the update! I will be sure to pull the changes and install the new versions. |
With commit 30979b0 we have published mkiocccentry 1.1 2024-05-19. |
Thanks for the update (though maybe I already pulled)! |
We believe we have addressed all of the current questions that still need answering at this time. If we've missed something or something else needs to be clarified, please ask again. |
Due to the fact that we have another issue that has had a number of OT comments I think it might be good to have a new mostly OT thread here rather than clutter the one in the other repo more or the issue for jprint.
I had the thought of suggesting you reopen the other one but there's a comment there I don't want to get lost that I hope you can finish replying to (you were doing it in parts) when things are less busy here. I also wanted to see if anything in particular occurs if one uses the same name (I rather doubt it will but it popped into my head anyway).
Feel free to assign this to me even though it's not technically an issue that has to be resolved.
The text was updated successfully, but these errors were encountered: