Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog URL in PR template not pointing to the right place #2131

Closed
ZiyaoWei opened this issue Aug 8, 2019 · 1 comment
Closed

Changelog URL in PR template not pointing to the right place #2131

ZiyaoWei opened this issue Aug 8, 2019 · 1 comment

Comments

@ZiyaoWei
Copy link
Contributor

ZiyaoWei commented Aug 8, 2019

The tiniest nitpick - the changelog link in the PR template actually points to https://github.com/iodide-project/iodide/CHANGELOG.md after PRs are submitted, e.g., #2130.

What I Did

N/A

What I Expected

The link should point at https://github.com/iodide-project/iodide/blob/master/CHANGELOG.md

What Happened

https://github.com/iodide-project/iodide/CHANGELOG.md which 404s

@wlach wlach closed this as completed in e3a13fd Aug 8, 2019
@wlach
Copy link
Contributor

wlach commented Aug 8, 2019

Thanks! For future reference, it is possible to submit PRs against these sorts of templates (see commit) -- feel free to do so in the future, no issue required. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants