Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build six using usual build system #1010

Merged
merged 7 commits into from Jan 2, 2021
Merged

Build six using usual build system #1010

merged 7 commits into from Jan 2, 2021

Conversation

dalcde
Copy link
Contributor

@dalcde dalcde commented Jan 2, 2021

No description provided.

@dalcde
Copy link
Contributor Author

dalcde commented Jan 2, 2021

The list of packages requiring six are obtained by

grep -r six packages/*/build/*/{setup.py,setup.cfg,*requirement*}

@dalcde dalcde requested a review from rth January 2, 2021 06:10
@dalcde
Copy link
Contributor Author

dalcde commented Jan 2, 2021

After this PR is merged, we can get rid of some six dependencies by upgrading the packages

Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM, assuming CI passes.

@dalcde dalcde merged commit 869044b into pyodide:master Jan 2, 2021
joemarshall pushed a commit to joemarshall/pyodide that referenced this pull request Jan 3, 2021
@rth
Copy link
Member

rth commented Jan 3, 2021

We also need to update the docs,

$ rg -A1 six docs/
docs/loading_packages.md
4:Only the Python standard library and [six](https://pypi.org/project/six/) are 
5-available after importing Pyodide.

@dalcde dalcde deleted the six branch January 10, 2021 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants