Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Change: Remove repr API #1067

Merged
merged 5 commits into from Jan 8, 2021
Merged

API Change: Remove repr API #1067

merged 5 commits into from Jan 8, 2021

Conversation

hoodmane
Copy link
Member

@hoodmane hoodmane commented Jan 7, 2021

The repr API is unnecessary (instead use PyProxy.toString or import repr from python yourself). Furthermore it has a bug that is like the reverse of the bug in #922:

>>> pyodide.repr.toString()
 TypeError: pyodide.repr is undefined
>>> pyodide.globals.toString()
"<module 'builtins' (built-in)>"
>>> pyodide.repr.toString()
"<built-in function repr>"

This was done in v0.15.0. The output is different now but the same bug is still here. I think the fact that nobody has reported this bug suggests that nobody was using this redundant API in the first place.

See also #1066 and #984.

@rth rth changed the title API Change: Remove weirdly behaved repr API API Change: Remove repr API Jan 7, 2021
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This needs a changelog entry as well.

@dalcde dalcde merged commit 42d9d6c into pyodide:master Jan 8, 2021
@hoodmane hoodmane deleted the remove-repr branch January 8, 2021 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants