Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setInterruptBuffer to public API, update changelog and docs #1173

Merged
merged 10 commits into from Jan 31, 2021
Merged

Add setInterruptBuffer to public API, update changelog and docs #1173

merged 10 commits into from Jan 31, 2021

Conversation

hoodmane
Copy link
Member

@hoodmane hoodmane commented Jan 24, 2021 •
edited

This minimally solves issue #676, though we may wish to wait to close it until we offer a more convenient webworker API.

@hoodmane hoodmane mentioned this pull request Jan 24, 2021
Merged
rth
rth reviewed Jan 29, 2021
View reviewed changes
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments otherwise LGTM. Thanks!

docs/project/changelog.md Outdated Show resolved Hide resolved
docs/usage/js-api/pyodide.setInterruptBuffer.md Outdated Show resolved Hide resolved
@hoodmane
Copy link
Member Author

@rth Okay I added the links to the relevant PRs and wrapped the lines at 80 chars using gq80. This changed some other stuff in the changelog but it looks like it'd been formatted with gq80 not that long ago. I manually fixed a bunch of little issues though.

@rth
Copy link
Member

rth commented Jan 31, 2021

Thanks!

@rth rth merged commit f9fb31d into pyodide:master Jan 31, 2021
@hoodmane hoodmane deleted the keyboard-interrupt-cleanup branch February 2, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hoodmane @rth