New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyProxy methods for iterators / iterables / generators #1180
Conversation
2c95d38
to
18d6f73
Compare
…tors / iterables / generators
18d6f73
to
5f6327c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @hoodmane,
great, this is just another fine pull request, and as @rth said your suggestions are very much appreciated here!
The hiwire.pop_value() replacement is also another good thing coming in with this.
I hope to contribute some more reviewing bandwidth during the next days.
On my first view all looks fine on this, maybe Roman has a comment therefore I first wait at the moment.
Thanks for the review @phorward. I really appreciate all the hard work you guys put into maintaining this project. I have faith you'll get to reviewing my PRs eventually =) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A PyProxy of an iterable Python object is now an iterable Javascript object,
a PyProxy of a Python iterator is now an Javascript iterator,
a PyProxy of a Python generator is now a Javascript generator.