Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyProxy methods for iterators / iterables / generators #1180

Merged
merged 8 commits into from Feb 4, 2021

Conversation

hoodmane
Copy link
Member

A PyProxy of an iterable Python object is now an iterable Javascript object,
a PyProxy of a Python iterator is now an Javascript iterator,
a PyProxy of a Python generator is now a Javascript generator.

@hoodmane hoodmane force-pushed the pyproxy-iter branch 2 times, most recently from 2c95d38 to 18d6f73 Compare January 31, 2021 04:31
@rth
Copy link
Member

rth commented Feb 1, 2021

Thanks @hoodmane ! This sounds great. Sorry not much review bandwidth at the moment, but all your suggested improvement are very much appreciated :) I'll try to have a look later in the week or next week. At the moment mostly focusing on #1102 as it's blocking a number long standing of issues.

Copy link
Contributor

@phorward phorward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @hoodmane,
great, this is just another fine pull request, and as @rth said your suggestions are very much appreciated here!
The hiwire.pop_value() replacement is also another good thing coming in with this.
I hope to contribute some more reviewing bandwidth during the next days.
On my first view all looks fine on this, maybe Roman has a comment therefore I first wait at the moment.

@hoodmane
Copy link
Member Author

hoodmane commented Feb 3, 2021

Thanks for the review @phorward. I really appreciate all the hard work you guys put into maintaining this project. I have faith you'll get to reviewing my PRs eventually =)

Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice! Please add a changelog entry.

Thanks @hoodmane and @phorward !

@rth rth merged commit 503741e into pyodide:master Feb 4, 2021
@hoodmane hoodmane deleted the pyproxy-iter branch February 4, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants