Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix format docs discrepancy #1255

Closed
wants to merge 1 commit into from
Closed

doc: fix format docs discrepancy #1255

wants to merge 1 commit into from

Conversation

brendanashworth
Copy link
Contributor

Only objects and symbols use util.inspect, others are simply
concatenated.

Fixes: #935
R=@cjihrig?

@mscdex
Copy link
Contributor

mscdex commented Mar 25, 2015

Shouldn't this target the doc subsystem?

@mscdex mscdex added the doc Issues and PRs related to the documentations. label Mar 25, 2015
@cjihrig
Copy link
Contributor

cjihrig commented Mar 25, 2015

LGTM, but as pointed out, please change the commit subsystem to doc.

@brendanashworth
doc: fix format docs discrepancy
a8fd9c4 
Only objects and symbols use `util.inspect`, others are simply
concatenated.

Fixes: nodejs#935
@brendanashworth brendanashworth changed the title util: fix format docs discrepancy doc: fix format docs discrepancy Mar 25, 2015
@brendanashworth
Copy link
Contributor Author

Ah, yes, thank you, I missed that. It's now been fixed, merging in a short while.

brendanashworth added a commit that referenced this pull request Mar 25, 2015
@brendanashworth
doc: fix format docs discrepancy
4581421 
Only objects and symbols use `util.inspect`, others are simply
concatenated.

Fixes: #935
PR-URL: #1255
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@brendanashworth
Copy link
Contributor Author

Thanks, this has been merged in 4581421.

@rvagg rvagg mentioned this pull request Mar 28, 2015
Closed
@brendanashworth brendanashworth deleted the fix-util-format-docs branch April 6, 2015 04:15
@Fishrock123 Fishrock123 mentioned this pull request Apr 9, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brendanashworth @mscdex @cjihrig