Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py check is deprecated #194

Closed
kitschen opened this issue Apr 15, 2020 · 2 comments
Closed

setup.py check is deprecated #194

kitschen opened this issue Apr 15, 2020 · 2 comments

Comments

@kitschen
Copy link

After generating a new project from the template, running tox shows the warning below. Should the template be adapted?

check run-test: commands[0] | python setup.py check --strict --metadata --restructuredtext
running check
warning: Check: This command has been deprecated. Use `twine check` instead: https://packaging.python.org/guides/making-a-pypi-friendly-readme#validating-restructuredtext-markup
@ionelmc
Copy link
Owner

ionelmc commented Apr 15, 2020

Yeah it's a known problem, I haven't gotten to a solution yet. I don't want have something worse, like #109, just to silence a harmless warning. Ideally there would be some publishing workflow where the dists would be checked like in the PR.

But why is a publishing workflow such a big deal you might ask? Dozens of projects have it right? Well, they don't have platform-specific wheels, so it's easy to publish the only two dists (sdist+wheel) in the same place.

@ionelmc ionelmc changed the title tox shows warning in default template output setup.py check is deprecated Apr 27, 2023
@ionelmc
Copy link
Owner

ionelmc commented Apr 27, 2023

Actually dupe of #108

@ionelmc ionelmc closed this as completed Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants